On Sat, Jan 13, 2024 at 4:43 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > The current test tries to ensure that > > > during shutdown after we shutdown walsender and ensures that it sends > > > all the wal records and receipts an ack for the same, there is no > > > other WAL except shutdown_checkpoint. Vignesh's suggestion (a) makes > > > the test robust enough that it shouldn't show spurious failures like > > > the current one reported by you, so shall we try to proceed with that? > > > > Do you mean something like [1]? It ensures the test passes unless any > > writes are added (in future) before the publisher restarts in the test > > which can again make the tests flaky. How do we ensure no one adds > > anything in before the publisher restart > > 038_save_logical_slots_shutdown.pl? A note before the restart perhaps? > > > > I am fine with adding the note.
Okay. Please see the attached patch. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
v1-0001-Fix-test-failure-in-038_save_logical_slots_shutdo.patch
Description: Binary data
