Re: [plpython] Add missing volatile qualifier.

2024-04-01 Thread Tom Lane
Nathan Bossart writes: > On Mon, Apr 01, 2024 at 11:57:07AM -0400, Tom Lane wrote: >> Good catch! It looks like the consequences of a failure would be >> pretty minimal --- AFAICS, no worse than a possible failure to remove >> a refcount on Py_None --- but that's still a bug. > Huh. I seem to h

Re: [plpython] Add missing volatile qualifier.

2024-04-01 Thread Nathan Bossart
On Mon, Apr 01, 2024 at 11:57:07AM -0400, Tom Lane wrote: > Xing Guo writes: >> I'm playing a toy static analysis checker with PostgreSQL and found a >> variable is missing volatile qualifier. > > Good catch! It looks like the consequences of a failure would be > pretty minimal --- AFAICS, no wo

Re: [plpython] Add missing volatile qualifier.

2024-04-01 Thread Tom Lane
Xing Guo writes: > I'm playing a toy static analysis checker with PostgreSQL and found a > variable is missing volatile qualifier. Good catch! It looks like the consequences of a failure would be pretty minimal --- AFAICS, no worse than a possible failure to remove a refcount on Py_None --- but