Nathan Bossart <nathandboss...@gmail.com> writes:
> On Mon, Apr 01, 2024 at 11:57:07AM -0400, Tom Lane wrote:
>> Good catch! It looks like the consequences of a failure would be
>> pretty minimal --- AFAICS, no worse than a possible failure to remove
>> a refcount on Py_None --- but that's still a bug.
> Huh. I seem to have dropped that "volatile" shortly before committing for
> some reason [0].
Oh, I'd forgotten that discussion. Given that we were both confused
about the need for it, all the more reason to try to avoid using a
within-PG_TRY assignment.
> Your fix seems fine to me.
Thanks for looking, I'll push it shortly.
regards, tom lane
