Re: [PATCH] Using named captures in Catalog::ParseHeader()

2023-06-30 Thread Dagfinn Ilmari Mannsåker
Michael Paquier writes: > On Wed, Jun 14, 2023 at 10:30:23AM +0100, Dagfinn Ilmari Mannsåker wrote: >> Thanks for the review! > > v17 is now open, so applied this one. Thanks for committing! - ilmari

Re: [PATCH] Using named captures in Catalog::ParseHeader()

2023-06-29 Thread Michael Paquier
On Wed, Jun 14, 2023 at 10:30:23AM +0100, Dagfinn Ilmari Mannsåker wrote: > Thanks for the review! v17 is now open, so applied this one. -- Michael signature.asc Description: PGP signature

Re: [PATCH] Using named captures in Catalog::ParseHeader()

2023-06-14 Thread Dagfinn Ilmari Mannsåker
Michael Paquier writes: > On Thu, Jun 01, 2023 at 01:12:22PM +0100, Dagfinn Ilmari Mannsåker wrote: >> While I was rewriting the regexes I noticed that they were inconsistent >> about whether they accepted whitespace in the parameter lists, so I took >> the liberty to make them consistently allow

Re: [PATCH] Using named captures in Catalog::ParseHeader()

2023-06-13 Thread Michael Paquier
On Thu, Jun 01, 2023 at 01:12:22PM +0100, Dagfinn Ilmari Mannsåker wrote: > While I was rewriting the regexes I noticed that they were inconsistent > about whether they accepted whitespace in the parameter lists, so I took > the liberty to make them consistently allow whitespace after the opening >

Re: [PATCH] Using named captures in Catalog::ParseHeader()

2023-06-13 Thread Dagfinn Ilmari Mannsåker
Dagfinn Ilmari Mannsåker writes: > However, now that we require Perl 5.14, we can use the named capture > feature (introduced in Perl 5.10) to make that a lot clearer, as in the > attached patch. Added to the open commitfest: https://commitfest.postgresql.org/43/4361/ - ilmari

Re: [PATCH] Using named captures in Catalog::ParseHeader()

2023-06-13 Thread John Naylor
On Thu, Jun 1, 2023 at 7:12 PM Dagfinn Ilmari Mannsåker wrote: > > Hi Hackers, > > Peter's patch set for autogenerating syscache info > (https://postgr.es/m/75ae5875-3abc-dafc-8aec-73247ed41cde%40eisentraut.org ) > touched on one of my least favourite parts of Catalog.pm: the > parenthesis-countin