On Thu, Jun 1, 2023 at 7:12 PM Dagfinn Ilmari Mannsåker <ilm...@ilmari.org> wrote: > > Hi Hackers, > > Peter's patch set for autogenerating syscache info > (https://postgr.es/m/75ae5875-3abc-dafc-8aec-73247ed41cde%40eisentraut.org ) > touched on one of my least favourite parts of Catalog.pm: the > parenthesis-counting nightmare that is the parsing of catalog header > directives. > > However, now that we require Perl 5.14, we can use the named capture > feature (introduced in Perl 5.10) to make that a lot clearer, as in the > attached patch. > > While I was rewriting the regexes I noticed that they were inconsistent > about whether they accepted whitespace in the parameter lists, so I took > the liberty to make them consistently allow whitespace after the opening > paren and the commas, which is what most of them already did.
LGTM -- John Naylor EDB: http://www.enterprisedb.com
