Re: [PATCH] Fix PostgreSQL server build and install problems under MSYS2

2019-11-11 Thread Guram Duka
Thank you for your comments. 1. The #if ... defined(__ cplusplus) is necessary for the successful compilation of C++ llvmjit code that uses C headers. 2. #if defined(HAVE_GSS_API_H) && !defined(GSS_DLLIMP) is necessary for the successful link libgss.a provided by MSYS2. 3. Remember that you need t

Re: [PATCH] Fix PostgreSQL server build and install problems under MSYS2

2019-11-11 Thread Michael Paquier
On Mon, Nov 11, 2019 at 10:56:51AM -0500, Tom Lane wrote: > This seems like it probably breaks a lot of other cases along the way. > Why have you made all these #if tests dependent on defined(__cplusplus)? > That's surely not specific to MSYS2. (I'm a bit bemused by the idea > that our code compil

Re: [PATCH] Fix PostgreSQL server build and install problems under MSYS2

2019-11-11 Thread Tom Lane
=?UTF-8?B?0JPRg9GA0LDQvCDQlNGD0LrQsA==?= writes: > I made a patch fixing build and install problems under MSYS2, including > llvmjit. This seems like it probably breaks a lot of other cases along the way. Why have you made all these #if tests dependent on defined(__cplusplus)? That's surely not s