=?UTF-8?B?0JPRg9GA0LDQvCDQlNGD0LrQsA==?= <guram.d...@gmail.com> writes:
> I made a patch fixing build and install problems under MSYS2, including
> llvmjit.

This seems like it probably breaks a lot of other cases along the way.
Why have you made all these #if tests dependent on defined(__cplusplus)?
That's surely not specific to MSYS2.  (I'm a bit bemused by the idea
that our code compiles at all on a C++ compiler; we have not tried
to make the .c files C++-clean.  But if it does work, this probably
breaks it for non-Windows cases.)

The GSSAPI changes seem like they might be better considered
separately from the basic problem of getting a working MSYS2 build.

In any case, you need to explain these changes individually,
not expect that we're just going to adopt them without questions.

                        regards, tom lane


Reply via email to