Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2019-12-17 Thread Jeff Janes
On Fri, Sep 7, 2018 at 9:17 AM Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 05/09/2018 18:46, Peter Eisentraut wrote: > > On 01/09/2018 06:33, Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote: > >> Certainly the PQconndefaults function specifies Debug flag for the > "options" o

RE: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-09-07 Thread Shinoda, Noriyoshi (PN Japan GCS Delivery)
iyoshi Shinoda -Original Message- From: Peter Eisentraut [mailto:peter.eisentr...@2ndquadrant.com] Sent: Friday, September 7, 2018 10:17 PM To: Shinoda, Noriyoshi (PN Japan GCS Delivery) ; fabriziome...@gmail.com; [pgdg] Robert Haas ; mich...@paquier.xyz Cc: Pgsql Hackers Subject: Re: [HACKER

Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-09-07 Thread Peter Eisentraut
On 05/09/2018 18:46, Peter Eisentraut wrote: > On 01/09/2018 06:33, Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote: >> Certainly the PQconndefaults function specifies Debug flag for the "options" >> option. >> I think that eliminating the Debug flag is the simplest solution. >> For attached pat

Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-09-05 Thread Peter Eisentraut
On 01/09/2018 06:33, Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote: > Certainly the PQconndefaults function specifies Debug flag for the "options" > option. > I think that eliminating the Debug flag is the simplest solution. > For attached patches, GUC can be specified with the following synta

RE: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-08-31 Thread Shinoda, Noriyoshi (PN Japan GCS Delivery)
very) ; fabriziome...@gmail.com; [pgdg] Robert Haas ; mich...@paquier.xyz Cc: Pgsql Hackers Subject: Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module On 28/08/2018 05:55, Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote: >>> I like the direction of your thinking, but

Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-08-31 Thread Masahiko Sawada
On Tue, Aug 28, 2018 at 12:55 PM, Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote: > Hi Everyone, thank you for your comment. > >>> I like the direction of your thinking, but it seems to me that this >>> would cause a problem if you want to set search_path=foo,bar. >>... OPTIONS ( host 'remhost1'

Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-08-30 Thread Peter Eisentraut
On 28/08/2018 05:55, Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote: >>> I like the direction of your thinking, but it seems to me that this >>> would cause a problem if you want to set search_path=foo,bar. >> ... OPTIONS ( host 'remhost1', port '5433', dbname 'demodb', >> option='option1=foo',

Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-08-30 Thread Kyotaro HORIGUCHI
At Mon, 27 Aug 2018 19:38:19 -0700, Michael Paquier wrote in <20180828023819.ga29...@paquier.xyz> > On Mon, Aug 27, 2018 at 02:34:31PM -0400, Robert Haas wrote: > > I like the direction of your thinking, but it seems to me that this > > would cause a problem if you want to set search_path=foo,bar

RE: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-08-27 Thread Shinoda, Noriyoshi (PN Japan GCS Delivery)
lo [mailto:fabriziome...@gmail.com] Sent: Tuesday, August 28, 2018 3:53 AM To: [pgdg] Robert Haas Cc: mich...@paquier.xyz; Shinoda, Noriyoshi (PN Japan GCS Delivery) ; Pgsql Hackers Subject: Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module On Mon, Aug 27, 2018 at 3:35 PM

Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-08-27 Thread Michael Paquier
On Mon, Aug 27, 2018 at 02:34:31PM -0400, Robert Haas wrote: > I like the direction of your thinking, but it seems to me that this > would cause a problem if you want to set search_path=foo,bar. proconfig already handles such cases, that's what I was coming at. We could reuse most of what it does

Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-08-27 Thread Fabrízio de Royes Mello
On Mon, Aug 27, 2018 at 3:35 PM Robert Haas wrote: > > On Mon, Aug 27, 2018 at 1:29 AM Michael Paquier wrote: > > It seems to me that you would pass down just a string which gets > > allocated for "options", and injection risks are something to be careful > > about. Another possibility would be

Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-08-27 Thread Robert Haas
On Mon, Aug 27, 2018 at 1:29 AM Michael Paquier wrote: > It seems to me that you would pass down just a string which gets > allocated for "options", and injection risks are something to be careful > about. Another possibility would be an array with comma-separated > arguments, say: > options = 'o

Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-08-26 Thread Michael Paquier
Hi Shinoda-san, On Sun, Aug 26, 2018 at 02:21:55AM +, Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote: > Thank you very much for your comment. > I will try to modify it so that GUC can be added more generically. It seems to me that you would pass down just a string which gets allocated for

RE: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-08-25 Thread Shinoda, Noriyoshi (PN Japan GCS Delivery)
urday, August 25, 2018 4:49 AM To: Shinoda, Noriyoshi (PN Japan GCS Delivery) Cc: pgsql-hack...@postgresql.org Subject: Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module On Fri, Aug 17, 2018 at 2:07 AM Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote: The attached patch

Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-08-24 Thread Robert Haas
On Fri, Aug 17, 2018 at 2:07 AM Shinoda, Noriyoshi (PN Japan GCS Delivery) < noriyoshi.shin...@hpe.com> wrote: > The attached patch adds a new option work_mem to postgres_fdw contrib > module. > > Previously, it was impossible to change the setting of work_mem for remote > session with connection

RE: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-08-23 Thread Shinoda, Noriyoshi (PN Japan GCS Delivery)
Hi, Hackers. I updated the patch that I attached the other day. Added release of dynamically allocated memory and modified source according to coding rule. Regards, Noriyoshi Shinoda -- From: Shinoda, Noriyoshi (PN Japan GCS Delivery) Sent: Friday, August 17, 2018 3:07 PM To: pgsql-hack...@post