Hi Everyone, thank you for your comment. >> I like the direction of your thinking, but it seems to me that this >> would cause a problem if you want to set search_path=foo,bar. >... OPTIONS ( host 'remhost1', port '5433', dbname 'demodb', >option='option1=foo', option='option2=bar' );
I do not want to allow postgres_fdw to set "all" GUCs. Because I think it is very difficult to check the validity of all input values. So, I attached modified the patch so that we can easily add GUC that we can set to postgres_fdw module. If you wish to add more GUC options to the module, add values to the non_libpq_options[] array of the InitPgFdwOptions function, And add the validator code for the GUC in the postgres_fdw_validator function. Best Regards, Noriyoshi Shinoda ------------- From: Fabrízio de Royes Mello [mailto:fabriziome...@gmail.com] Sent: Tuesday, August 28, 2018 3:53 AM To: [pgdg] Robert Haas <robertmh...@gmail.com> Cc: mich...@paquier.xyz; Shinoda, Noriyoshi (PN Japan GCS Delivery) <noriyoshi.shin...@hpe.com>; Pgsql Hackers <pgsql-hack...@postgresql.org> Subject: Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module On Mon, Aug 27, 2018 at 3:35 PM Robert Haas <robertmh...@gmail.com> wrote: > > On Mon, Aug 27, 2018 at 1:29 AM Michael Paquier <mich...@paquier.xyz> wrote: > > It seems to me that you would pass down just a string which gets > > allocated for "options", and injection risks are something to be careful > > about. Another possibility would be an array with comma-separated > > arguments, say: > > options = 'option1=foo,option2=bar' > > There is already some work done with comma-separated arguments for the > > parameter "extensions", now that's more work. > > I like the direction of your thinking, but it seems to me that this > would cause a problem if you want to set search_path=foo,bar. > Maybe we can use multiple "options". Something like: ... OPTIONS ( host 'remhost1', port '5433', dbname 'demodb', option='option1=foo', option='option2=bar' ); Regards, -- Fabrízio de Royes Mello Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
postgres_fdw_work_mem_v3.patch
Description: postgres_fdw_work_mem_v3.patch
