On Tue, Jun 20, 2023 at 9:02 AM Peter Smith wrote:
>
> FYI - I have created and tested back-patches for Amit's v5 patch,
> going all the way to REL_10_STABLE.
>
Pushed. I haven't used PG10 patch as REL_10_STABLE is out of support now.
--
With Regards,
Amit Kapila.
FYI - I have created and tested back-patches for Amit's v5 patch,
going all the way to REL_10_STABLE.
(the patches needed tweaking several times due to minor code/docs
differences in the earlier versions)
PSA.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
logical_replication_slot_disable
On Fri, Jun 16, 2023 at 7:15 PM Peter Eisentraut wrote:
>
> On 15.06.23 04:49, Amit Kapila wrote:
> >
> > Now, along with this change, there is a change in errhint as well
> > which I am not sure about whether to backpatch or not. I think we have
> > the following options (a) commit both doc and c
On 15.06.23 04:49, Amit Kapila wrote:
I wanted to backpatch the following change which provides somewhat
accurate information about what a user needs to do when it faces an
error.
To proceed in
- this situation, disassociate the subscription from the replication slot by
- executing ALTER SUBS
On Wed, Jun 14, 2023 at 6:52 PM Peter Eisentraut wrote:
>
> On 14.06.23 05:09, Amit Kapila wrote:
> > The latest version looks good to me as well. I think we should
> > backpatch this change as this is a user-facing message change in docs
> > and code. What do you guys think?
>
> Isn't that a reas
On 14.06.23 05:09, Amit Kapila wrote:
The latest version looks good to me as well. I think we should
backpatch this change as this is a user-facing message change in docs
and code. What do you guys think?
Isn't that a reason *not* to backpatch it?
On Wed, Jun 14, 2023 at 9:25 AM Peter Smith wrote:
>
> On Wed, Jun 14, 2023 at 1:10 PM Amit Kapila wrote:
> >
> > On Wed, May 17, 2023 at 11:57 AM Peter Smith wrote:
> > >
> > > On Wed, May 17, 2023 at 2:53 PM Robert Sjöblom
> > > wrote:
> > > >
> > > > Attached is the revised version.
> > > >
On Wed, Jun 14, 2023 at 1:10 PM Amit Kapila wrote:
>
> On Wed, May 17, 2023 at 11:57 AM Peter Smith wrote:
> >
> > On Wed, May 17, 2023 at 2:53 PM Robert Sjöblom
> > wrote:
> > >
> > > Attached is the revised version.
> > >
> >
> > v4 looks good to me.
> >
>
> The latest version looks good to me
On Wed, May 17, 2023 at 11:57 AM Peter Smith wrote:
>
> On Wed, May 17, 2023 at 2:53 PM Robert Sjöblom
> wrote:
> >
> > Attached is the revised version.
> >
>
> v4 looks good to me.
>
The latest version looks good to me as well. I think we should
backpatch this change as this is a user-facing me
On Wed, May 17, 2023 at 2:53 PM Robert Sjöblom
wrote:
>
> Den ons 17 maj 2023 kl 03:18 skrev Peter Smith :
> >
> > + errhint("Use %s to disassociate the subscription from the slot after
> > disabling the subscription.",
> >
> > IMO it looked strange having the word "subscription" 2x in the same
>
Den ons 17 maj 2023 kl 03:18 skrev Peter Smith :
>
> + errhint("Use %s to disassociate the subscription from the slot after
> disabling the subscription.",
>
> IMO it looked strange having the word "subscription" 2x in the same sentence.
>
> Maybe you can reword the errhint like:
>
> BEFORE
> "Use
+ errhint("Use %s to disassociate the subscription from the slot after
disabling the subscription.",
IMO it looked strange having the word "subscription" 2x in the same sentence.
Maybe you can reword the errhint like:
BEFORE
"Use %s to disassociate the subscription from the slot after disabling
Den tis 16 maj 2023 kl 01:44 skrev Peter Smith :
>
> On Mon, May 15, 2023 at 11:36 PM Robert Sjöblom
> wrote:
> >
> >
> >
> > On 2023-05-05 15:17, Robert Sjöblom wrote:
> > >
> > > Hi,
> > >
> > > We have recently used the PostgreSQL documentation when setting up our
> > > logical replication. We
On Mon, May 15, 2023 at 11:36 PM Robert Sjöblom
wrote:
>
>
>
> On 2023-05-05 15:17, Robert Sjöblom wrote:
> >
> > Hi,
> >
> > We have recently used the PostgreSQL documentation when setting up our
> > logical replication. We noticed there was a step missing in the
> > documentation on how to drop
On 2023-05-05 15:17, Robert Sjöblom wrote:
Hi,
We have recently used the PostgreSQL documentation when setting up our
logical replication. We noticed there was a step missing in the
documentation on how to drop a logical replication subscription with a
replication slot attached.
Followin
On Tue, May 9, 2023 at 3:40 PM Amit Kapila wrote:
>
> On Mon, May 8, 2023 at 1:51 PM Masahiko Sawada wrote:
> >
> > Apart from the documentation change, given that setting slot_name =
> > NONE always requires for the subscription to be disabled beforehand,
> > does it make sense to change ALTER S
On Mon, May 8, 2023 at 1:51 PM Masahiko Sawada wrote:
>
> Apart from the documentation change, given that setting slot_name =
> NONE always requires for the subscription to be disabled beforehand,
> does it make sense to change ALTER SUBSCRIPTION SET so that we disable
> the subscription when sett
On Mon, May 8, 2023 at 12:07 PM Amit Kapila wrote:
>
> On Fri, May 5, 2023 at 6:47 PM Robert Sjöblom
> wrote:
> >
> > We have recently used the PostgreSQL documentation when setting up our
> > logical replication. We noticed there was a step missing in the
> > documentation on how to drop a logi
On Fri, May 5, 2023 at 11:17 PM Robert Sjöblom
wrote:
>
>
> Hi,
>
> We have recently used the PostgreSQL documentation when setting up our
> logical replication. We noticed there was a step missing in the
> documentation on how to drop a logical replication subscription with a
> replication slot a
On Fri, May 5, 2023 at 6:47 PM Robert Sjöblom wrote:
>
> We have recently used the PostgreSQL documentation when setting up our
> logical replication. We noticed there was a step missing in the
> documentation on how to drop a logical replication subscription with a
> replication slot attached.
>
20 matches
Mail list logo
