Re: [BUG] Unexpected action when publishing partition tables

2021-10-17 Thread Amit Kapila
On Mon, Oct 18, 2021 at 12:24 PM Amit Kapila wrote: > > On Wed, Oct 13, 2021 at 9:11 AM Amit Langote wrote: > > Anyway, I'll think a bit more about the possible hazards of not doing > > the locking and will reply again if there's indeed a problem(s) that > > needs to be fixed. > > > > I think you

Re: [BUG] Unexpected action when publishing partition tables

2021-10-17 Thread Amit Kapila
On Wed, Oct 13, 2021 at 9:11 AM Amit Langote wrote: > > Hi Amit, > > On Fri, Oct 8, 2021 at 12:47 PM Amit Kapila wrote: > > On Thu, Oct 7, 2021 at 12:39 PM Amit Langote > > wrote: > > > Sorry that I didn't comment on this earlier, but I think either > > > GetPubPartitionOptionRelations() or Inv

Re: [BUG] Unexpected action when publishing partition tables

2021-10-12 Thread Amit Langote
Hi Amit, On Fri, Oct 8, 2021 at 12:47 PM Amit Kapila wrote: > On Thu, Oct 7, 2021 at 12:39 PM Amit Langote wrote: > > Sorry that I didn't comment on this earlier, but I think either > > GetPubPartitionOptionRelations() or InvalidatePublicationRels() > > introduced in the commit 4548c76738b shoul

Re: [BUG] Unexpected action when publishing partition tables

2021-10-07 Thread Amit Kapila
On Thu, Oct 7, 2021 at 12:39 PM Amit Langote wrote: > > On Fri, Sep 17, 2021 at 7:38 PM Amit Kapila wrote: > > On Fri, Sep 17, 2021 at 11:36 AM houzj.f...@fujitsu.com > > wrote: > > > On Thursday, September 16, 2021 6:05 PM Amit Kapila > > > > > > > > On Tuesday, September 14, 2021 10:41 PM vi

Re: [BUG] Unexpected action when publishing partition tables

2021-10-07 Thread Amit Langote
On Fri, Sep 17, 2021 at 7:38 PM Amit Kapila wrote: > On Fri, Sep 17, 2021 at 11:36 AM houzj.f...@fujitsu.com > wrote: > > On Thursday, September 16, 2021 6:05 PM Amit Kapila > > > > > > On Tuesday, September 14, 2021 10:41 PM vignesh C > > > > wrote: > > > > > On Tue, Sep 7, 2021 at 11:38 AM

Re: [BUG] Unexpected action when publishing partition tables

2021-09-22 Thread Amit Kapila
On Fri, Sep 17, 2021 at 4:07 PM Amit Kapila wrote: > > Thanks, your patches look good to me. I'll push them sometime next > week after Tuesday unless there are any comments. > Pushed. -- With Regards, Amit Kapila.

Re: [BUG] Unexpected action when publishing partition tables

2021-09-17 Thread Amit Kapila
On Fri, Sep 17, 2021 at 11:36 AM houzj.f...@fujitsu.com wrote: > > On Thursday, September 16, 2021 6:05 PM Amit Kapila > > > On Tuesday, September 14, 2021 10:41 PM vignesh C > > > wrote: > > > > On Tue, Sep 7, 2021 at 11:38 AM houzj.f...@fujitsu.com > > > > wrote: > > > > > > Thanks for the

RE: [BUG] Unexpected action when publishing partition tables

2021-09-16 Thread houzj.f...@fujitsu.com
On Thursday, September 16, 2021 6:05 PM Amit Kapila > > On Tuesday, September 14, 2021 10:41 PM vignesh C > > wrote: > > > On Tue, Sep 7, 2021 at 11:38 AM houzj.f...@fujitsu.com > > > wrote: > > > > Thanks for the comment. > > Attach new version patches which clean the table at the end. > > >

Re: [BUG] Unexpected action when publishing partition tables

2021-09-16 Thread Amit Kapila
On Thu, Sep 16, 2021 at 7:15 AM houzj.f...@fujitsu.com wrote: > > On Tuesday, September 14, 2021 10:41 PM vignesh C wrote: > > On Tue, Sep 7, 2021 at 11:38 AM houzj.f...@fujitsu.com > > wrote: > > Thanks for the comment. > Attach new version patches which clean the table at the end. > + * For

RE: [BUG] Unexpected action when publishing partition tables

2021-09-15 Thread houzj.f...@fujitsu.com
On Tuesday, September 14, 2021 10:41 PM vignesh C wrote: > On Tue, Sep 7, 2021 at 11:38 AM houzj.f...@fujitsu.com > wrote: > > > > > > Attach new version patches which addressed the comment. > > Thanks for fixing this issue. The bug gets fixed by the patch, I did not find > any > issues in my

Re: [BUG] Unexpected action when publishing partition tables

2021-09-14 Thread vignesh C
On Tue, Sep 7, 2021 at 11:38 AM houzj.f...@fujitsu.com wrote: > > From Tues, Sep 7, 2021 12:02 PM Amit Kapila wrote: > > On Mon, Sep 6, 2021 at 1:49 PM houzj.f...@fujitsu.com > > wrote: > > > > > > I can reproduce this bug. > > > > > > I think the reason is it didn't invalidate all the leaf par

RE: [BUG] Unexpected action when publishing partition tables

2021-09-07 Thread tanghy.f...@fujitsu.com
> > > --- > > > PublicationAddTables > > > publication_add_relation > > > /* Invalidate relcache so that publication info is > > > rebuilt. */ > > > CacheInvalidateRelcache(targetrel); > > > --- > > > > > > In addition, this problem can happen in both ADD TA

RE: [BUG] Unexpected action when publishing partition tables

2021-09-06 Thread houzj.f...@fujitsu.com
From Tues, Sep 7, 2021 12:02 PM Amit Kapila wrote: > On Mon, Sep 6, 2021 at 1:49 PM houzj.f...@fujitsu.com > wrote: > > > > I can reproduce this bug. > > > > I think the reason is it didn't invalidate all the leaf partitions' > > relcache when add a partitioned table to the publication, so the >

Re: [BUG] Unexpected action when publishing partition tables

2021-09-06 Thread Amit Kapila
On Mon, Sep 6, 2021 at 1:49 PM houzj.f...@fujitsu.com wrote: > > From Mon, Sep 6, 2021 3:59 PM tanghy.f...@fujitsu.com > wrote: > > I met a problem when using logical replication. Maybe it's a bug in logical > > replication. > > When publishing a partition table without replica identity, update

RE: [BUG] Unexpected action when publishing partition tables

2021-09-06 Thread houzj.f...@fujitsu.com
>From Mon, Sep 6, 2021 3:59 PM tanghy.f...@fujitsu.com > wrote: > I met a problem when using logical replication. Maybe it's a bug in logical > replication. > When publishing a partition table without replica identity, update > or delete operation can be successful in some cases. > > For example: