Re: [BUG] Partition creation fails after dropping a column and adding a partial index

2019-11-01 Thread Michael Paquier
On Fri, Nov 01, 2019 at 09:58:26AM +0900, Amit Langote wrote: > On Thu, Oct 31, 2019 at 1:45 PM Michael Paquier wrote: >> The patch is rather simple as per the attached, with extended >> regression tests included. I have not checked on back-branches yet, >> but that's visibly wrong since 8b08f7d

Re: [BUG] Partition creation fails after dropping a column and adding a partial index

2019-10-31 Thread Amit Langote
On Thu, Oct 31, 2019 at 1:45 PM Michael Paquier wrote: > On Tue, Oct 29, 2019 at 01:16:58PM +0900, Michael Paquier wrote: > > Yes, something looks wrong with that. I have not looked at it in > > details yet though. I'll see about that tomorrow. > > So.. When building the attribute map for a clo

Re: [BUG] Partition creation fails after dropping a column and adding a partial index

2019-10-31 Thread Ibrar Ahmed
On Thu, Oct 31, 2019 at 9:45 AM Michael Paquier wrote: > On Tue, Oct 29, 2019 at 01:16:58PM +0900, Michael Paquier wrote: > > Yes, something looks wrong with that. I have not looked at it in > > details yet though. I'll see about that tomorrow. > > So.. When building the attribute map for a cl

Re: [BUG] Partition creation fails after dropping a column and adding a partial index

2019-10-30 Thread Michael Paquier
On Tue, Oct 29, 2019 at 01:16:58PM +0900, Michael Paquier wrote: > Yes, something looks wrong with that. I have not looked at it in > details yet though. I'll see about that tomorrow. So.. When building the attribute map for a cloned index (with either LIKE during the transformation or for part

Re: [BUG] Partition creation fails after dropping a column and adding a partial index

2019-10-28 Thread Wyatt Alt
Here's a slightly smaller repro: https://gist.github.com/wkalt/36720f39c97567fa6cb18cf5c05ac60f

Re: [BUG] Partition creation fails after dropping a column and adding a partial index

2019-10-28 Thread Michael Paquier
On Mon, Oct 28, 2019 at 09:00:24PM -0700, Wyatt Alt wrote: > I think this demonstrates a bug, tested in 11.5: > https://gist.github.com/wkalt/a298fe82c564668c803b3537561e67a0 If this source goes away, then we would lose it. It is always better to copy directly the example in the message sent to t