On Fri, Nov 01, 2019 at 09:58:26AM +0900, Amit Langote wrote: > On Thu, Oct 31, 2019 at 1:45 PM Michael Paquier <mich...@paquier.xyz> wrote: >> The patch is rather simple as per the attached, with extended >> regression tests included. I have not checked on back-branches yet, >> but that's visibly wrong since 8b08f7d down to v11 (will do that when >> back-patching). > > The patch looks correct and applies to both v12 and v11.
Thanks for the review, committed down to v11. The version for v11 had a couple of conflicts actually. >> There could be a point in changing convert_tuples_by_name_map & co so >> as they return the length of the map on top of the map to avoid such >> mistakes in the future. That's a more invasive patch not really >> adapted for a back-patch, but we could do that on HEAD once this bug >> is fixed. I have also checked other calls of this API and the >> handling is done correctly. > > I've been bitten by this logical error when deciding what length to > use for the map, so seems like a good idea. Okay, let's see about that then. -- Michael
signature.asc
Description: PGP signature
