On Tue, Oct 09, 2018 at 10:12:17AM +0200, 'Christoph Moench-Tegeder' wrote:
> Attached is the updated patch. I made sure the function's OID hadn't been
> taken otherwise, and it compiles and works in a quick check.
Committed, after some slight adjustments. Files in
pg_wal/archive_status/ have nor
## Michael Paquier (mich...@paquier.xyz):
> Thanks Iwata-san. I was just trying to apply the patch but it failed so
> the new status is fine. On top of taking care of the rebase, please
> make sure of the following:
OK, that was an easy one.
> - Calling pg_ls_dir_files() with missing_ok set to
On Tue, Oct 09, 2018 at 02:14:52AM +, Iwata, Aya wrote:
> Sorry, I made a mistake. You patch currently does not apply. Kindly
> rebase the patch. I'm marking it as "Waiting on Author".
Thanks Iwata-san. I was just trying to apply the patch but it failed so
the new status is fine. On top of
> I didn't find any problems with the patch, so I'm marking it as "Ready for
> Committer".
Sorry, I made a mistake. You patch currently does not apply. Kindly rebase the
patch.
I'm marking it as "Waiting on Author".
Regards,
Aya Iwata
Hi Christoph,
> > All similar function are named pg_ls_***dir. It is clear these
> > functions return directory contents information.
> > If the new function intends to display the contents of the directory,
> > pg_ls_***dir style might be better (e.g. pg_ls_archive_statusdir).
> > But everyone kn
Hi,
## Iwata, Aya (iwata@jp.fujitsu.com):
> I think it is convenient to be able to check the archive_status
> directory contents information.
>
> I reviewed patch. It applies and passes regression test.
Great, thanks!
> All similar function are named pg_ls_***dir. It is clear these functio
Hi Christoph,
I think it is convenient to be able to check the archive_status directory
contents information.
I reviewed patch. It applies and passes regression test.
I checked the code.
It refers to the patch which added pg_ls_waldir() and pg_ls_logdir(), so I
think it is good.
There is one
## Michael Paquier (mich...@paquier.xyz):
> Okay, could you add this patch to the next commit fest? Here it is:
> https://commitfest.postgresql.org/20/
And here's the patch: https://commitfest.postgresql.org/20/1813/
Regards,
Christoph
--
Spare Space
On Sun, Sep 30, 2018 at 10:59:20PM +0200, Christoph Moench-Tegeder wrote:
> Without further ado, I present a patch to implement pg_ls_archive_status(),
> which fills this gap. I believe the function name is long enough and we
> don't need an extra wal in there. The patch is based on a very recent
>