On Thu, Jan 9, 2020 at 4:41 PM Mahendra Singh Thalor wrote:
>
> On Mon, 9 Dec 2019 at 14:37, Amit Kapila wrote:
> >
> > On Mon, Dec 9, 2019 at 2:27 PM Amit Kapila wrote:
> > >
> > > I have modified the patch for the above points and additionally ran
> > > pgindent. Let me know what you think ab
On Mon, 9 Dec 2019 at 14:37, Amit Kapila wrote:
>
> On Mon, Dec 9, 2019 at 2:27 PM Amit Kapila
wrote:
> >
> > I have modified the patch for the above points and additionally ran
> > pgindent. Let me know what you think about the attached patch?
> >
>
> A new version with a slightly modified comm
On Mon, Dec 9, 2019 at 2:37 PM Amit Kapila wrote:
>
> On Mon, Dec 9, 2019 at 2:27 PM Amit Kapila wrote:
> >
> > I have modified the patch for the above points and additionally ran
> > pgindent. Let me know what you think about the attached patch?
> >
>
> A new version with a slightly modified co
On Mon, Dec 9, 2019 at 2:27 PM Amit Kapila wrote:
>
> I have modified the patch for the above points and additionally ran
> pgindent. Let me know what you think about the attached patch?
>
A new version with a slightly modified commit message.
--
With Regards,
Amit Kapila.
EnterpriseDB: http:/
On Fri, Oct 25, 2019 at 9:22 PM Masahiko Sawada wrote:
>
> On Wed, Oct 23, 2019 at 8:14 PM Amit Kapila wrote:
> >
> > On Tue, Oct 22, 2019 at 2:17 PM Dilip Kumar wrote:
> > >
> > > On Tue, Oct 22, 2019 at 10:53 AM Amit Kapila
> > > wrote:
> > >
> > > I have modified as we discussed. Please ta
On Wed, Oct 23, 2019 at 8:14 PM Amit Kapila wrote:
>
> On Tue, Oct 22, 2019 at 2:17 PM Dilip Kumar wrote:
> >
> > On Tue, Oct 22, 2019 at 10:53 AM Amit Kapila
> > wrote:
> > >
> > > > Basically, only IndexBulkDeleteResult is now shared across the stage
> > > > so we can move all members to Gist
On Tue, Oct 22, 2019 at 2:17 PM Dilip Kumar wrote:
>
> On Tue, Oct 22, 2019 at 10:53 AM Amit Kapila wrote:
> >
> > > Basically, only IndexBulkDeleteResult is now shared across the stage
> > > so we can move all members to GistVacState and completely get rid of
> > > GistBulkDeleteResult?
> > >
>
On Tue, Oct 22, 2019 at 10:53 AM Amit Kapila wrote:
>
> On Tue, Oct 22, 2019 at 10:50 AM Dilip Kumar wrote:
> >
> > On Tue, Oct 22, 2019 at 9:10 AM Amit Kapila wrote:
> > >
> > > On Fri, Oct 18, 2019 at 4:51 PM Dilip Kumar wrote:
> > > >
> > > > I have prepared a first version of the patch. Cu
On Tue, Oct 22, 2019 at 10:50 AM Dilip Kumar wrote:
>
> On Tue, Oct 22, 2019 at 9:10 AM Amit Kapila wrote:
> >
> > On Fri, Oct 18, 2019 at 4:51 PM Dilip Kumar wrote:
> > >
> > > I have prepared a first version of the patch. Currently, I am
> > > performing an empty page deletion for all the cas
On Tue, Oct 22, 2019 at 9:10 AM Amit Kapila wrote:
>
> On Fri, Oct 18, 2019 at 4:51 PM Dilip Kumar wrote:
> >
> > I have prepared a first version of the patch. Currently, I am
> > performing an empty page deletion for all the cases.
> >
>
> Few comments:
> --
> 1.
> -/*
> - *
On Fri, Oct 18, 2019 at 4:51 PM Dilip Kumar wrote:
>
> I have prepared a first version of the patch. Currently, I am
> performing an empty page deletion for all the cases.
>
Few comments:
--
1.
-/*
- * State kept across vacuum stages.
- */
typedef struct
{
- IndexBulkDelete
On Mon, Oct 21, 2019 at 2:58 PM Andrey Borodin wrote:
>
>
>
> > 21 окт. 2019 г., в 11:12, Dilip Kumar написал(а):
> >
> > On Mon, Oct 21, 2019 at 2:30 PM Andrey Borodin wrote:
> >>
> >> I've took a look into the patch, and cannot understand one simple thing...
> >> We should not call gistvacuum_
> 21 окт. 2019 г., в 11:12, Dilip Kumar написал(а):
>
> On Mon, Oct 21, 2019 at 2:30 PM Andrey Borodin wrote:
>>
>> I've took a look into the patch, and cannot understand one simple thing...
>> We should not call gistvacuum_delete_empty_pages() for same gist_stats twice.
>> Another way once
On Mon, Oct 21, 2019 at 2:30 PM Andrey Borodin wrote:
>
> Hi!
>
> > 18 окт. 2019 г., в 13:21, Dilip Kumar написал(а):
> >
> > On Fri, Oct 18, 2019 at 10:55 AM Amit Kapila
> > wrote:
> >>
> >>
> >> I think we can do it in general as adding some check for parallel
> >> vacuum there will look bit
Hi!
> 18 окт. 2019 г., в 13:21, Dilip Kumar написал(а):
>
> On Fri, Oct 18, 2019 at 10:55 AM Amit Kapila wrote:
>>
>>
>> I think we can do it in general as adding some check for parallel
>> vacuum there will look bit hackish.
> I agree with that point.
> It is not clear if we get enough
>> be
On Mon, Oct 21, 2019 at 11:23 AM Amit Kapila wrote:
>
> On Fri, Oct 18, 2019 at 10:48 AM Amit Kapila wrote:
> >
> > Thanks for the test. It shows that prior to patch the memory was
> > getting leaked in TopTransactionContext during multi-pass vacuum and
> > after patch, there is no leak. I will
On Fri, Oct 18, 2019 at 10:48 AM Amit Kapila wrote:
>
> Thanks for the test. It shows that prior to patch the memory was
> getting leaked in TopTransactionContext during multi-pass vacuum and
> after patch, there is no leak. I will commit the patch early next
> week unless Heikki or someone want
On Fri, Oct 18, 2019 at 10:55 AM Amit Kapila wrote:
>
> On Fri, Oct 18, 2019 at 9:41 AM Dilip Kumar wrote:
> >
> > On Wed, Oct 16, 2019 at 7:22 PM Heikki Linnakangas wrote:
> > >
> > > On 16 October 2019 12:57:03 CEST, Amit Kapila
> > > wrote:
> > > >On Tue, Oct 15, 2019 at 7:13 PM Heikki Linn
On Fri, Oct 18, 2019 at 9:41 AM Dilip Kumar wrote:
>
> On Wed, Oct 16, 2019 at 7:22 PM Heikki Linnakangas wrote:
> >
> > On 16 October 2019 12:57:03 CEST, Amit Kapila
> > wrote:
> > >On Tue, Oct 15, 2019 at 7:13 PM Heikki Linnakangas
> > >wrote:
> > >> All things
> > >> considered, I'm not sur
On Fri, Oct 18, 2019 at 9:34 AM Dilip Kumar wrote:
>
> On Thu, Oct 17, 2019 at 6:32 PM Dilip Kumar wrote:
> >
> > On Thu, 17 Oct 2019, 14:59 Amit Kapila, wrote:
> >>
> >> On Thu, Oct 17, 2019 at 1:47 PM Dilip Kumar wrote:
> >> >
> >> > On Thu, Oct 17, 2019 at 12:27 PM Heikki Linnakangas
> >>
On Wed, Oct 16, 2019 at 7:22 PM Heikki Linnakangas wrote:
>
> On 16 October 2019 12:57:03 CEST, Amit Kapila wrote:
> >On Tue, Oct 15, 2019 at 7:13 PM Heikki Linnakangas
> >wrote:
> >> All things
> >> considered, I'm not sure which is better.
> >
> >Yeah, this is a tough call to make, but if we c
On Thu, Oct 17, 2019 at 6:32 PM Dilip Kumar wrote:
>
> On Thu, 17 Oct 2019, 14:59 Amit Kapila, wrote:
>>
>> On Thu, Oct 17, 2019 at 1:47 PM Dilip Kumar wrote:
>> >
>> > On Thu, Oct 17, 2019 at 12:27 PM Heikki Linnakangas
>> > wrote:
>> > >
>> > > On 17/10/2019 05:31, Amit Kapila wrote:
>> > >
On Thu, 17 Oct 2019, 14:59 Amit Kapila, wrote:
> On Thu, Oct 17, 2019 at 1:47 PM Dilip Kumar wrote:
> >
> > On Thu, Oct 17, 2019 at 12:27 PM Heikki Linnakangas
> wrote:
> > >
> > > On 17/10/2019 05:31, Amit Kapila wrote:
> > > >
> > > > The patch looks good to me. I have slightly modified the
On Thu, Oct 17, 2019 at 1:47 PM Dilip Kumar wrote:
>
> On Thu, Oct 17, 2019 at 12:27 PM Heikki Linnakangas wrote:
> >
> > On 17/10/2019 05:31, Amit Kapila wrote:
> > >
> > > The patch looks good to me. I have slightly modified the comments and
> > > removed unnecessary initialization.
> > >
> >
On Thu, Oct 17, 2019 at 12:27 PM Heikki Linnakangas wrote:
>
> On 17/10/2019 05:31, Amit Kapila wrote:
> > On Wed, Oct 16, 2019 at 11:20 AM Dilip Kumar wrote:
> >>
> >> On Tue, Oct 15, 2019 at 7:13 PM Heikki Linnakangas wrote:
> >>>
> >>> On 15/10/2019 09:37, Amit Kapila wrote:
> While revi
On 17/10/2019 05:31, Amit Kapila wrote:
On Wed, Oct 16, 2019 at 11:20 AM Dilip Kumar wrote:
On Tue, Oct 15, 2019 at 7:13 PM Heikki Linnakangas wrote:
On 15/10/2019 09:37, Amit Kapila wrote:
While reviewing a parallel vacuum patch [1], we noticed a few things
about $SUBJECT implemented in c
On Thu, Oct 17, 2019 at 9:15 AM Amit Kapila wrote:
>
> On Wed, Oct 16, 2019 at 7:21 PM Heikki Linnakangas wrote:
> >
> > On 16 October 2019 12:57:03 CEST, Amit Kapila
> > wrote:
> > >On Tue, Oct 15, 2019 at 7:13 PM Heikki Linnakangas
> > >wrote:
> > >> All things
> > >> considered, I'm not sur
On Wed, Oct 16, 2019 at 7:21 PM Heikki Linnakangas wrote:
>
> On 16 October 2019 12:57:03 CEST, Amit Kapila wrote:
> >On Tue, Oct 15, 2019 at 7:13 PM Heikki Linnakangas
> >wrote:
> >> All things
> >> considered, I'm not sure which is better.
> >
> >Yeah, this is a tough call to make, but if we c
On Wed, Oct 16, 2019 at 11:20 AM Dilip Kumar wrote:
>
> On Tue, Oct 15, 2019 at 7:13 PM Heikki Linnakangas wrote:
> >
> > On 15/10/2019 09:37, Amit Kapila wrote:
> > > While reviewing a parallel vacuum patch [1], we noticed a few things
> > > about $SUBJECT implemented in commit -
> > > 7df159a62
On 16 October 2019 12:57:03 CEST, Amit Kapila wrote:
>On Tue, Oct 15, 2019 at 7:13 PM Heikki Linnakangas
>wrote:
>> All things
>> considered, I'm not sure which is better.
>
>Yeah, this is a tough call to make, but if we can allow it to delete
>the pages in bulkdelete conditionally for parallel v
On Tue, Oct 15, 2019 at 7:13 PM Heikki Linnakangas wrote:
>
> On 15/10/2019 09:37, Amit Kapila wrote:
> > 2. Right now, in gistbulkdelete we make a note of empty leaf pages and
> > internals pages and then in the second pass during gistvacuumcleanup,
> > we delete all the empty leaf pages. I was
On Tue, Oct 15, 2019 at 7:13 PM Heikki Linnakangas wrote:
>
> On 15/10/2019 09:37, Amit Kapila wrote:
> > While reviewing a parallel vacuum patch [1], we noticed a few things
> > about $SUBJECT implemented in commit -
> > 7df159a620b760e289f1795b13542ed1b3e13b87.
> >
> > 1. A new memory context Gi
On 15/10/2019 09:37, Amit Kapila wrote:
While reviewing a parallel vacuum patch [1], we noticed a few things
about $SUBJECT implemented in commit -
7df159a620b760e289f1795b13542ed1b3e13b87.
1. A new memory context GistBulkDeleteResult->page_set_context has
been introduced, but it doesn't seem to
While reviewing a parallel vacuum patch [1], we noticed a few things
about $SUBJECT implemented in commit -
7df159a620b760e289f1795b13542ed1b3e13b87.
1. A new memory context GistBulkDeleteResult->page_set_context has
been introduced, but it doesn't seem to be used.
2. Right now, in gistbulkdelete
34 matches
Mail list logo
