Re: Potentially misleading name of libpq pass phrase hook

2020-05-16 Thread Andrew Dunstan
On 5/16/20 7:47 PM, Tom Lane wrote: > Daniel Gustafsson writes: >>> On 16 May 2020, at 03:56, Michael Paquier wrote: >>> Agreed. PQsslKeyPassHook__type sounds fine to me as >>> convention. Wouldn't we want to also rename PQsetSSLKeyPassHook and >>> PQgetSSLKeyPassHook, appending an "_OpenSSL"

Re: Potentially misleading name of libpq pass phrase hook

2020-05-16 Thread Tom Lane
Daniel Gustafsson writes: >> On 16 May 2020, at 03:56, Michael Paquier wrote: >> Agreed. PQsslKeyPassHook__type sounds fine to me as >> convention. Wouldn't we want to also rename PQsetSSLKeyPassHook and >> PQgetSSLKeyPassHook, appending an "_OpenSSL" to both? > Yes, I think we should. The at

Re: Potentially misleading name of libpq pass phrase hook

2020-05-16 Thread Jonathan S. Katz
On 5/16/20 3:16 AM, Daniel Gustafsson wrote: >> On 16 May 2020, at 03:56, Michael Paquier wrote: >> >> On Fri, May 15, 2020 at 09:21:52PM -0400, Jonathan S. Katz wrote: >>> +1 on all of the above. >>> >>> I noticed this has been added to Open Items; I added a note that the >>> plan is to fix befor

Re: Potentially misleading name of libpq pass phrase hook

2020-05-16 Thread Andrew Dunstan
On 5/15/20 8:08 PM, Alvaro Herrera wrote: > On 2020-May-15, Magnus Hagander wrote: > >> On Thu, May 14, 2020 at 3:03 PM Daniel Gustafsson wrote: >>> Since we haven't shipped this there is still time to rename, which >>> IMO is the right way forward. PQsslKeyPassHook__type would >>> be one optio

Re: Potentially misleading name of libpq pass phrase hook

2020-05-16 Thread Daniel Gustafsson
> On 16 May 2020, at 03:56, Michael Paquier wrote: > > On Fri, May 15, 2020 at 09:21:52PM -0400, Jonathan S. Katz wrote: >> +1 on all of the above. >> >> I noticed this has been added to Open Items; I added a note that the >> plan is to fix before the Beta 1 wrap. > > +1. Thanks. > > Agreed.

Re: Potentially misleading name of libpq pass phrase hook

2020-05-15 Thread Michael Paquier
On Fri, May 15, 2020 at 09:21:52PM -0400, Jonathan S. Katz wrote: > +1 on all of the above. > > I noticed this has been added to Open Items; I added a note that the > plan is to fix before the Beta 1 wrap. +1. Thanks. Agreed. PQsslKeyPassHook__type sounds fine to me as convention. Wouldn't we

Re: Potentially misleading name of libpq pass phrase hook

2020-05-15 Thread Jonathan S. Katz
On 5/15/20 8:21 PM, Tom Lane wrote: > Magnus Hagander writes: >> On Thu, May 14, 2020 at 3:03 PM Daniel Gustafsson wrote: >>> Since we haven't shipped this there is still time to rename, which IMO >>> is the right way forward. PQsslKeyPassHook__type would be one >>> option, but perhaps there are

Re: Potentially misleading name of libpq pass phrase hook

2020-05-15 Thread Tom Lane
Magnus Hagander writes: > On Thu, May 14, 2020 at 3:03 PM Daniel Gustafsson wrote: >> Since we haven't shipped this there is still time to rename, which IMO >> is the right way forward. PQsslKeyPassHook__type would be one >> option, but perhaps there are better alternatives? > ISTM this should

Re: Potentially misleading name of libpq pass phrase hook

2020-05-15 Thread Alvaro Herrera
On 2020-May-15, Magnus Hagander wrote: > On Thu, May 14, 2020 at 3:03 PM Daniel Gustafsson wrote: > > Since we haven't shipped this there is still time to rename, which > > IMO is the right way forward. PQsslKeyPassHook__type would > > be one option, but perhaps there are better alternatives? >

Re: Potentially misleading name of libpq pass phrase hook

2020-05-15 Thread Magnus Hagander
On Thu, May 14, 2020 at 3:03 PM Daniel Gustafsson wrote: > Reviewing TLS changes for v13 I came across one change which I think might > be > better off with a library qualified name. The libpq frontend sslpassword > hook > added in 4dc63552109f65 is OpenSSL specific, but it has a very generic >

Potentially misleading name of libpq pass phrase hook

2020-05-14 Thread Daniel Gustafsson
Reviewing TLS changes for v13 I came across one change which I think might be better off with a library qualified name. The libpq frontend sslpassword hook added in 4dc63552109f65 is OpenSSL specific, but it has a very generic name: PQsetSSLKeyPassHook(PQsslKeyPassHook_type hook); This I