> On 16 May 2020, at 03:56, Michael Paquier <mich...@paquier.xyz> wrote: > > On Fri, May 15, 2020 at 09:21:52PM -0400, Jonathan S. Katz wrote: >> +1 on all of the above. >> >> I noticed this has been added to Open Items; I added a note that the >> plan is to fix before the Beta 1 wrap. > > +1. Thanks. > > Agreed. PQsslKeyPassHook_<library>_type sounds fine to me as > convention. Wouldn't we want to also rename PQsetSSLKeyPassHook and > PQgetSSLKeyPassHook, appending an "_OpenSSL" to both?
Yes, I think we should. The attached performs the rename of the hook functions and the type, and also fixes an off-by-one-'=' in a header comment which my OCD couldn't unsee. cheers ./daniel
openssl_hook_rename.patch
Description: Binary data