Re: [PATCH] PGSERVICEFILE as part of a normal connection string

2025-04-13 Thread Ryo Kanbayashi
On Mon, Apr 7, 2025 at 1:10 PM Michael Paquier wrote: > > On Thu, Apr 03, 2025 at 12:36:59AM +0900, Ryo Kanbayashi wrote: > > I'll reflect your notice and suggestion to the patch current I'm > > working on :) > > Thanks for that. > > And I have forgotten to add you as a reviewer of what has been >

Re: [PATCH] PGSERVICEFILE as part of a normal connection string

2025-04-06 Thread Michael Paquier
On Thu, Apr 03, 2025 at 12:36:59AM +0900, Ryo Kanbayashi wrote: > I'll reflect your notice and suggestion to the patch current I'm > working on :) Thanks for that. And I have forgotten to add you as a reviewer of what has been committed as 2c7bd2ba507e. Sorry for that :/ -- Michael signature.a

Re: [PATCH] PGSERVICEFILE as part of a normal connection string

2025-04-06 Thread Michael Paquier
On Mon, Mar 31, 2025 at 04:26:27PM -0500, Andrew Jackson wrote: > I am working on a feature adjacent to the connection service functionality > and noticed some issues with the tests introduced in this thread. Basically > they incorrectly invoke the append perl function by passing multiple > strings

Re: [PATCH] PGSERVICEFILE as part of a normal connection string

2025-04-02 Thread Ryo Kanbayashi
On Tue, Apr 1, 2025 at 6:26 AM Andrew Jackson wrote: > > Hi, > > I am working on a feature adjacent to the connection service functionality > and noticed some issues with the tests introduced in this thread. Basically > they incorrectly invoke the append perl function by passing multiple strings

Re: [PATCH] PGSERVICEFILE as part of a normal connection string

2025-03-31 Thread Andrew Jackson
Hi, I am working on a feature adjacent to the connection service functionality and noticed some issues with the tests introduced in this thread. Basically they incorrectly invoke the append perl function by passing multiple strings to append when the function only takes one string to append. This

Re: [PATCH] PGSERVICEFILE as part of a normal connection string

2025-03-29 Thread Ryo Kanbayashi
On Sat, Mar 29, 2025 at 3:35 PM Ryo Kanbayashi wrote: > On Fri, Mar 28, 2025 at 8:57 AM Michael Paquier wrote: > > > I am not sure that I'll have the time to look at 0002 for this release > > > cycle, could it be possible to get a rebase for it? > > Here is a simple rebase that I have been able t

Re: [PATCH] PGSERVICEFILE as part of a normal connection string

2025-03-29 Thread Ryo Kanbayashi
On Fri, Mar 28, 2025 at 10:44 AM Michael Paquier wrote: > > On Thu, Mar 27, 2025 at 06:31:14PM +0900, Michael Paquier wrote: > > With all that in mind and more documentation added to the test, I've > > applied 0001, so let's see what the buildfarm has to say. The CI was > > stable, so it's a star

Re: [PATCH] PGSERVICEFILE as part of a normal connection string

2025-03-27 Thread Michael Paquier
On Thu, Mar 27, 2025 at 06:31:14PM +0900, Michael Paquier wrote: > With all that in mind and more documentation added to the test, I've > applied 0001, so let's see what the buildfarm has to say. The CI was > stable, so it's a start. The buildfarm (particularly the Windows members that worried me

Re: [PATCH] PGSERVICEFILE as part of a normal connection string

2025-03-27 Thread Michael Paquier
On Thu, Mar 27, 2025 at 06:31:14PM +0900, Michael Paquier wrote: > I am not sure that I'll have the time to look at 0002 for this release > cycle, could it be possible to get a rebase for it? Here is a simple rebase that I have been able to assemble this morning. I won't have the space to review

Re: [PATCH] PGSERVICEFILE as part of a normal connection string

2025-03-27 Thread Michael Paquier
On Sun, Mar 23, 2025 at 12:32:03PM +0900, Ryo Kanbayashi wrote: > Additional test scripts have been merged to a single script ^^ b I have spent quite a bit of time on the review 0001 with the new tests to get something in for this release, and there was quite a bit going on there: - The script sho

Re: [PATCH] PGSERVICEFILE as part of a normal connection string

2025-03-22 Thread Ryo Kanbayashi
On Sat, Mar 22, 2025 at 4:46 PM Michael Paquier wrote: > > On Thu, Mar 20, 2025 at 06:16:44PM +0900, Ryo Kanbayashi wrote: > > Sorry, I found a miss on 006_service.pl. > > Fixed patch is attached... > > Please note that the commit fest app needs all the patches of a a set > to be posted in the sam

Re: [PATCH] PGSERVICEFILE as part of a normal connection string

2025-03-22 Thread Michael Paquier
On Thu, Mar 20, 2025 at 06:16:44PM +0900, Ryo Kanbayashi wrote: > Sorry, I found a miss on 006_service.pl. > Fixed patch is attached... Please note that the commit fest app needs all the patches of a a set to be posted in the same message. In this case, v2-0001 is not going to get automatic test

[PATCH] PGSERVICEFILE as part of a normal connection string

2025-03-20 Thread Ryo Kanbayashi
On Thu, Mar 20, 2025 at 5:39 PM Ryo Kanbayashi wrote: > > On Mon, Jan 27, 2025 at 2:01 PM Michael Paquier wrote: > > On Thu, Mar 13, 2025 at 08:53:49AM +0900, Ryo Kanbayashi wrote: > > > Putting a bit of context here. Most of the Postgres hackers based in > > > Japan had a meeting last Friday, a

Re: PGSERVICEFILE as part of a normal connection string

2025-03-20 Thread Ryo Kanbayashi
On Mon, Jan 27, 2025 at 2:01 PM Michael Paquier wrote: > On Thu, Mar 13, 2025 at 08:53:49AM +0900, Ryo Kanbayashi wrote: > > Putting a bit of context here. Most of the Postgres hackers based in > > Japan had a meeting last Friday, and Kanbayashi-san has asked me about > > patches that introduce t

Re: PGSERVICEFILE as part of a normal connection string

2025-03-15 Thread Ryo Kanbayashi
On Thu, Mar 13, 2025 at 9:42 AM Michael Paquier wrote: > > On Thu, Mar 13, 2025 at 08:53:49AM +0900, Ryo Kanbayashi wrote: > > If you can't work for ther patch for a while because you are busy or > > other some reason, > > I can become additinal reviewer and apply review comments from Micael > >

Re: PGSERVICEFILE as part of a normal connection string

2025-03-12 Thread Laurenz Albe
On Thu, 2025-03-13 at 08:53 +0900, Ryo Kanbayashi wrote: > Just to let you know, my action is not intended to steal your > contribution but to prevent your good idea from being lost. > > TO: Mecael and other hackers, > > There are any problem in light of community customs? Anything submitted to

Re: PGSERVICEFILE as part of a normal connection string

2025-03-12 Thread Michael Paquier
On Thu, Mar 13, 2025 at 08:53:49AM +0900, Ryo Kanbayashi wrote: > If you can't work for ther patch for a while because you are busy or > other some reason, > I can become additinal reviewer and apply review comments from Micael > to the patch instead of you. > > If you don't want my action, plea

Re: PGSERVICEFILE as part of a normal connection string

2025-03-12 Thread Ryo Kanbayashi
On Mon, Jan 27, 2025 at 2:01 PM Michael Paquier wrote: > > On Wed, Nov 20, 2024 at 02:58:43AM -0500, Corey Huinker wrote: > > Currently, a lot of our utility scripts (anything that uses > > connectDatabase) don't support service=name params or PGSERVICE=name env > > vars, which is really too bad.

Re: PGSERVICEFILE as part of a normal connection string

2025-01-26 Thread Michael Paquier
On Wed, Nov 20, 2024 at 02:58:43AM -0500, Corey Huinker wrote: > Currently, a lot of our utility scripts (anything that uses > connectDatabase) don't support service=name params or PGSERVICE=name env > vars, which is really too bad. I previously thought that this was because > of a lack of interest

Re: PGSERVICEFILE as part of a normal connection string

2024-11-19 Thread Corey Huinker
> > > > Interesting. We've never had tests for that even for "service". > Perhaps it would be the time to add some tests for the existing case > and the one you are adding? Your test suite should make that easy to > add. > Currently, a lot of our utility scripts (anything that uses connectDatab

Re: PGSERVICEFILE as part of a normal connection string

2024-11-19 Thread Michael Paquier
On Mon, Nov 18, 2024 at 09:21:56PM +0100, Torsten Förtsch wrote: > I like to bundle all my database connections in a .pg_service.conf. Over > time I collected a bunch of such service files. A while back I discovered > that the service file can only be specified as an environment variable. It > cann

Re: PGSERVICEFILE as part of a normal connection string

2024-11-18 Thread Laurenz Albe
On Mon, 2024-11-18 at 21:21 +0100, Torsten Förtsch wrote: > I like to bundle all my database connections in a .pg_service.conf. Over time > I > collected a bunch of such service files. A while back I discovered that the > service file can only be specified as an environment variable. It cannot be

PGSERVICEFILE as part of a normal connection string

2024-11-18 Thread Torsten Förtsch
Hi, I like to bundle all my database connections in a .pg_service.conf. Over time I collected a bunch of such service files. A while back I discovered that the service file can only be specified as an environment variable. It cannot be given as part of the connection string like psql "service=$MY