Re: PATCH: Add Table Access Method option to pgbench

2022-07-20 Thread Alexander Korotkov
Hi! On Tue, Jul 19, 2022 at 4:47 AM Michael Paquier wrote: > On Mon, Jul 18, 2022 at 01:53:21PM +0300, Alexander Korotkov wrote: > > Looks good to me as well. I'm going to push this if no objections. > > FWIW, I find the extra mention of PGOPTIONS with the specific point of > table AMs added wit

Re: PATCH: Add Table Access Method option to pgbench

2022-07-18 Thread Michael Paquier
On Mon, Jul 18, 2022 at 01:53:21PM +0300, Alexander Korotkov wrote: > Looks good to me as well. I'm going to push this if no objections. FWIW, I find the extra mention of PGOPTIONS with the specific point of table AMs added within the part of the environment variables a bit confusing, because we

Re: PATCH: Add Table Access Method option to pgbench

2022-07-18 Thread Alexander Korotkov
On Mon, Jul 18, 2022 at 12:08 AM Mason Sharp wrote: > On Wed, Jul 13, 2022 at 12:33 AM Michel Pelletier wrote: >> >> On Thu, 30 Jun 2022 at 18:09, Michael Paquier wrote: >>> >>> On Fri, Jul 01, 2022 at 10:06:49AM +0900, Michael Paquier wrote: >>> > And the conclusion back then is that one can al

Re: PATCH: Add Table Access Method option to pgbench

2022-07-17 Thread Mason Sharp
On Wed, Jul 13, 2022 at 12:33 AM Michel Pelletier wrote: > On Thu, 30 Jun 2022 at 18:09, Michael Paquier wrote: > >> On Fri, Jul 01, 2022 at 10:06:49AM +0900, Michael Paquier wrote: >> > And the conclusion back then is that one can already achieve this by >> > using PGOPTIONS: >> > PGOPTIONS='-c

Re: PATCH: Add Table Access Method option to pgbench

2022-07-12 Thread Michel Pelletier
On Thu, 30 Jun 2022 at 18:09, Michael Paquier wrote: > On Fri, Jul 01, 2022 at 10:06:49AM +0900, Michael Paquier wrote: > > And the conclusion back then is that one can already achieve this by > > using PGOPTIONS: > > PGOPTIONS='-c default_table_access_method=wuzza' pgbench [...] > > > > So there

Re: PATCH: Add Table Access Method option to pgbench

2022-06-30 Thread Michael Paquier
On Fri, Jul 01, 2022 at 10:06:49AM +0900, Michael Paquier wrote: > And the conclusion back then is that one can already achieve this by > using PGOPTIONS: > PGOPTIONS='-c default_table_access_method=wuzza' pgbench [...] > > So there is no need to complicate more pgbench, particularly when it > com

Re: PATCH: Add Table Access Method option to pgbench

2022-06-30 Thread Michael Paquier
On Thu, Jun 30, 2022 at 01:07:53PM -0700, Michel Pelletier wrote: > I've got CI setup and building and the tests now pass, I was missing a > CASCADE in my test. New patch attached: The exact same patch has been proposed back in November 2020: https://www.postgresql.org/message-id/0177f78c-4702-69

Re: PATCH: Add Table Access Method option to pgbench

2022-06-30 Thread Michel Pelletier
I've got CI setup and building and the tests now pass, I was missing a CASCADE in my test. New patch attached: On Thu, 30 Jun 2022 at 10:50, Michel Pelletier wrote: > On Thu, 30 Jun 2022 at 09:51, Justin Pryzby wrote: > >> On Thu, Jun 30, 2022 at 09:09:17AM -0700, Michel Pelletier wrote: >>

Re: PATCH: Add Table Access Method option to pgbench

2022-06-30 Thread Michel Pelletier
On Thu, 30 Jun 2022 at 09:51, Justin Pryzby wrote: > On Thu, Jun 30, 2022 at 09:09:17AM -0700, Michel Pelletier wrote: > > This change was originally authored by Alexander Korotkov, I have updated > > it and added a test to the pgbench runner. I'm hoping to make the > deadline > > for this curre

Re: PATCH: Add Table Access Method option to pgbench

2022-06-30 Thread Justin Pryzby
On Thu, Jun 30, 2022 at 09:09:17AM -0700, Michel Pelletier wrote: > This change was originally authored by Alexander Korotkov, I have updated > it and added a test to the pgbench runner. I'm hoping to make the deadline > for this currently open Commit Fest? This is failing check-world http://cfbo

PATCH: Add Table Access Method option to pgbench

2022-06-30 Thread Michel Pelletier
Hello! This patch adds a `--tableam=TABLEAM` option to the pgbench command line which allows the user to specify which table am is used to create tables initialized with `-i`. This change was originally authored by Alexander Korotkov, I have updated it and added a test to the pgbench runner. I'm