Re: New process of getting changes into the commitfest app

2025-01-31 Thread Jelte Fennema-Nio
On Thu, 23 Jan 2025 at 13:57, Jelte Fennema-Nio wrote: > # Proposal for new process I just announced an upcoming commitfest app release[1], following the discussion on this topic at the FOSDEM dev meeting. The rest of the conclusion is that we'll roughly follow the approach outlined in this orig

Re: New process of getting changes into the commitfest app

2025-01-27 Thread Melanie Plageman
On Thu, Jan 23, 2025 at 7:57 AM Jelte Fennema-Nio wrote: > > (Resent because sending to both -hackers and -www gets emails put in > the moderation queue, and I don't want to introduce that delay to all > replies. If you received the previous version because you're in the CC > please only reply to

Re: New process of getting changes into the commitfest app

2025-01-27 Thread Jelte Fennema-Nio
On Mon, 27 Jan 2025 at 05:38, Umar Hayat wrote: > +1 in github you can enforce a minimum number of reviewers. IMO there > should be a minimum of two reviewers and one of the reviewers should > be from the security group/role. In a perfect world I'd agree, but I don't think there are currently eno

Re: New process of getting changes into the commitfest app

2025-01-27 Thread Jelte Fennema-Nio
On Sat, 25 Jan 2025 at 06:29, Akshat Jaimini wrote: > I'll be happy to submit a PR with some basic tests on the repository. Sounds good, what basic tests do you have in mind? I have this auto-formatting PR open that also adds some github actions: https://github.com/JelteF/commitfest/pull/1

Re: New process of getting changes into the commitfest app

2025-01-27 Thread Jelte Fennema-Nio
On Sun, 26 Jan 2025 at 19:09, Yura Sokolov wrote: > Given history of libxz backdoor, I'd fear to give "commit access" for > anything critical to rather fresh member of community. That's definitely a valid concern in the general case, but I wouldn't call myself a fresh member of the community. I'v

Re: New process of getting changes into the commitfest app

2025-01-26 Thread Jacob Brazeal
> > Magnus wants reviews before deployment to be required, in an effort to > get as close-to-perfect commits as possible. I, on the other hand, > think that the benefit of close-to-perfect commits is not worth the > delays in deploying that those reviews currently introduce. I'd rather > deploy cod

Re: New process of getting changes into the commitfest app

2025-01-26 Thread Umar Hayat
On Mon, 27 Jan 2025 at 03:09, Yura Sokolov wrote: > > 23.01.2025 15:57, Jelte Fennema-Nio пишет: > > (Resent because sending to both -hackers and -www gets emails put in > > the moderation queue, and I don't want to introduce that delay to all > > replies. If you received the previous version beca

Re: New process of getting changes into the commitfest app

2025-01-26 Thread Yura Sokolov
23.01.2025 15:57, Jelte Fennema-Nio пишет: (Resent because sending to both -hackers and -www gets emails put in the moderation queue, and I don't want to introduce that delay to all replies. If you received the previous version because you're in the CC please only reply to this one) # Background

Re: New process of getting changes into the commitfest app

2025-01-24 Thread Akshat Jaimini
This seems like a great idea ! Maybe we can start out by adding some basic CI tests on the mirror repository to sort of 'dry run' the new process? I'll be happy to submit a PR with some basic tests on the repository. Regards, Akshat Jaimini On Thu, Jan 23, 2025 at 6:48 PM Jelte Fennema-Nio wro

Re: New process of getting changes into the commitfest app

2025-01-23 Thread Jelte Fennema-Nio
On Thu, 23 Jan 2025 at 01:25, Jacob Brazeal wrote: >> >> Magnus wants reviews before deployment to be required, in an effort to >> get as close-to-perfect commits as possible. I, on the other hand, >> think that the benefit of close-to-perfect commits is not worth the >> delays in deploying that

New process of getting changes into the commitfest app

2025-01-23 Thread Jelte Fennema-Nio
(Resent because sending to both -hackers and -www gets emails put in the moderation queue, and I don't want to introduce that delay to all replies. If you received the previous version because you're in the CC please only reply to this one) # Background As some of you might have noticed I've been