Re: Mop-up for the bootstrap data conversion patch

2018-04-07 Thread Michael Paquier
On Sat, Apr 07, 2018 at 09:25:44AM -0300, Alvaro Herrera wrote: > Tom Lane wrote: >> I've always felt that the pg_foo_fn.h business was a kluge, and would >> be happy to get rid of it. But one could also argue that it would be >> a good design, if we adopted it uniformly instead of haphazardly. >>

Re: Mop-up for the bootstrap data conversion patch

2018-04-07 Thread Alvaro Herrera
Tom Lane wrote: > I've always felt that the pg_foo_fn.h business was a kluge, and would > be happy to get rid of it. But one could also argue that it would be > a good design, if we adopted it uniformly instead of haphazardly. > But that'd require more code churn, and there's no longer a lot to b

Mop-up for the bootstrap data conversion patch

2018-04-06 Thread Tom Lane
Those of you who've been paying attention to the bootstrap data conversion thread will know that one of the key ideas is to put everything in the catalog headers that's of direct use to client-side code into separate "pg_foo_d.h" headers. This allows clients to include pg_foo_d.h to get OID macros