Re: Minor refactorings to eliminate some static buffers

2024-08-06 Thread Heikki Linnakangas
On 06/08/2024 23:41, Peter Eisentraut wrote: On 06.08.24 17:13, Heikki Linnakangas wrote: > --- a/src/backend/access/transam/xlogprefetcher.c > +++ b/src/backend/access/transam/xlogprefetcher.c > @@ -362,7 +362,7 @@ XLogPrefetcher * > XLogPrefetcherAllocate(XLogReaderState *reader) >

Re: Minor refactorings to eliminate some static buffers

2024-08-06 Thread Peter Eisentraut
On 06.08.24 17:13, Heikki Linnakangas wrote: > --- a/src/backend/access/transam/xlogprefetcher.c > +++ b/src/backend/access/transam/xlogprefetcher.c > @@ -362,7 +362,7 @@ XLogPrefetcher * > XLogPrefetcherAllocate(XLogReaderState *reader) > { > XLogPrefetcher *prefetcher; > - static

Re: Minor refactorings to eliminate some static buffers

2024-08-06 Thread Heikki Linnakangas
On 06/08/2024 18:52, Andres Freund wrote: On 2024-08-06 18:13:56 +0300, Heikki Linnakangas wrote: diff --git a/src/backend/tcop/utility.c b/src/backend/tcop/utility.c index 702a6c3a0b..2732d6bfc9 100644 --- a/src/backend/tcop/utility.c +++ b/src/backend/tcop/utility.c @@ -1155,7 +1155,7 @@ Proce

Re: Minor refactorings to eliminate some static buffers

2024-08-06 Thread Andres Freund
Hi, On 2024-08-06 18:13:56 +0300, Heikki Linnakangas wrote: > From 6dd5a4a413212a61d9a4f5b9db73e812c8b5dcbd Mon Sep 17 00:00:00 2001 > From: Heikki Linnakangas > Date: Tue, 6 Aug 2024 17:58:29 +0300 > Subject: [PATCH 1/5] Turn a few 'validnsps' static variables into locals > > There was no need

Re: Minor refactorings to eliminate some static buffers

2024-08-06 Thread Heikki Linnakangas
Here's another batch of little changes in the same vein. Mostly converting static bufs that are never modified to consts. -- Heikki Linnakangas Neon (https://neon.tech) From 6dd5a4a413212a61d9a4f5b9db73e812c8b5dcbd Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Tue, 6 Aug 2024 17:58:29

Re: Minor refactorings to eliminate some static buffers

2024-07-30 Thread Heikki Linnakangas
On 30/07/2024 18:44, Robert Haas wrote: On Tue, Jul 30, 2024 at 7:22 AM Heikki Linnakangas wrote: As part of the multithreading work, it'd be nice to get rid of as many global or static variables as possible. Remaining ones can be converted to thread locals as appropriate, but where possible, i

Re: Minor refactorings to eliminate some static buffers

2024-07-30 Thread Robert Haas
On Tue, Jul 30, 2024 at 7:22 AM Heikki Linnakangas wrote: > As part of the multithreading work, it'd be nice to get rid of as many > global or static variables as possible. Remaining ones can be converted > to thread locals as appropriate, but where possible, it's better to just > get rid of them.

Minor refactorings to eliminate some static buffers

2024-07-30 Thread Heikki Linnakangas
As part of the multithreading work, it'd be nice to get rid of as many global or static variables as possible. Remaining ones can be converted to thread locals as appropriate, but where possible, it's better to just get rid of them. Here are patches to get rid of a few static variables, by e.g