On Tue, Jul 30, 2024 at 7:22 AM Heikki Linnakangas <hlinn...@iki.fi> wrote: > As part of the multithreading work, it'd be nice to get rid of as many > global or static variables as possible. Remaining ones can be converted > to thread locals as appropriate, but where possible, it's better to just > get rid of them. > > Here are patches to get rid of a few static variables, by e.g. > converting them to regular local variables or palloc'd return values, as > appropriate. > > This doesn't move the needle much, but every little helps, and these > seem like nice little changes in any case.
I spent a few minutes looking through these patches and they seem like good cleanups. I couldn't think of a plausible reason why someone would object to any of these. -- Robert Haas EDB: http://www.enterprisedb.com