Re: Minor comment fix for pg_config_manual.h

2018-12-30 Thread Ian Barwick
On 12/29/18 8:27 AM, Michael Paquier wrote: On Fri, Dec 28, 2018 at 12:37:41AM -0300, Alvaro Herrera wrote: Looks good to me. Thanks for the lookup. I have committed and back-patched to v11 for consistency. Thanks! Regards Ian Barwick -- Ian Barwick http://www.2ndQua

Re: Minor comment fix for pg_config_manual.h

2018-12-28 Thread Michael Paquier
On Fri, Dec 28, 2018 at 12:37:41AM -0300, Alvaro Herrera wrote: > Looks good to me. Thanks for the lookup. I have committed and back-patched to v11 for consistency. -- Michael signature.asc Description: PGP signature

Re: Minor comment fix for pg_config_manual.h

2018-12-27 Thread Alvaro Herrera
On 2018-Dec-28, Michael Paquier wrote: > On Wed, Dec 26, 2018 at 09:36:57AM +0900, Michael Paquier wrote: > > like the attached perhaps? At the same time I am thinking about > > reformulating the second sentence as well.. > > > > /* > > - * This is default value for wal_segment_size to be used a

Re: Minor comment fix for pg_config_manual.h

2018-12-27 Thread Michael Paquier
On Wed, Dec 26, 2018 at 09:36:57AM +0900, Michael Paquier wrote: > like the attached perhaps? At the same time I am thinking about > reformulating the second sentence as well.. > > /* > - * This is default value for wal_segment_size to be used at initdb when run > - * without --walsegsize option.

Re: Minor comment fix for pg_config_manual.h

2018-12-25 Thread Michael Paquier
On Tue, Dec 25, 2018 at 10:22:30AM -0500, Tom Lane wrote: > The text still seems a bit awkward. Maybe "... to be used when initdb > is run without the ..." like the attached perhaps? At the same time I am thinking about reformulating the second sentence as well.. -- Michael diff --git a/src/incl

Re: Minor comment fix for pg_config_manual.h

2018-12-25 Thread Tom Lane
Michael Paquier writes: > On Mon, Dec 24, 2018 at 01:05:25PM +0900, Ian Barwick wrote: >> Attached is mainly to fix a comment in $subject which has a typo in >> the referenced initdb option ("--walsegsize", should be >> "--wal-segsize"), and while I'm there also adds a couple of "the" >> for reada

Re: Minor comment fix for pg_config_manual.h

2018-12-24 Thread Michael Paquier
On Mon, Dec 24, 2018 at 01:05:25PM +0900, Ian Barwick wrote: > Attached is mainly to fix a comment in $subject which has a typo in > the referenced initdb option ("--walsegsize", should be > "--wal-segsize"), and while I'm there also adds a couple of "the" > for readability. All that (the error as

Minor comment fix for pg_config_manual.h

2018-12-23 Thread Ian Barwick
Hi Attached is mainly to fix a comment in $subject which has a typo in the referenced initdb option ("--walsegsize", should be "--wal-segsize"), and while I'm there also adds a couple of "the" for readability. Regards Ian Barwick -- Ian Barwick http://www.2ndQuadrant.com/