On 2018-Dec-28, Michael Paquier wrote: > On Wed, Dec 26, 2018 at 09:36:57AM +0900, Michael Paquier wrote: > > like the attached perhaps? At the same time I am thinking about > > reformulating the second sentence as well.. > > > > /* > > - * This is default value for wal_segment_size to be used at initdb when run > > - * without --walsegsize option. Must be a valid segment size. > > + * This is the default value for wal_segment_size to be used when initdb > > is run > > + * without the --wal-segsize option. It must be a valid segment size. > > */ > > #define DEFAULT_XLOG_SEG_SIZE (16*1024*1024) > > So, any objections with this change? If somebody has a better > wording, please feel free to chime in.
Looks good to me. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
