Re: Memory allocation abstraction in pgcrypto

2020-09-24 Thread Michael Paquier
On Wed, Sep 23, 2020 at 04:57:44PM +0900, Michael Paquier wrote: > I doubt that anybody has been compiling with PX_OWN_ALLOC in the last > years, so let's remove this abstraction. And +1 for your patch. So, I have looked at that this morning again, and applied the thing. -- Michael signature.as

Re: Memory allocation abstraction in pgcrypto

2020-09-23 Thread Michael Paquier
On Fri, Sep 18, 2020 at 10:00:04PM +0200, Daniel Gustafsson wrote: > The attached removes it in favor of using palloc() et.al directly. Is there > any reason to keep it around still? I doubt that anybody has been compiling with PX_OWN_ALLOC in the last years, so let's remove this abstraction. An

Memory allocation abstraction in pgcrypto

2020-09-18 Thread Daniel Gustafsson
pgcrypto has an abstraction for palloc/pfree via PX_OWN_ALLOC with the intention to make it easy to swap out for another allocator. There are however a number of palloc calls that have snuck in over the years, so the abstraction is leaking a fair bit making it less useful. Since there have been n