Re: Make mesage at end-of-recovery less scary.

At Wed, 17 Jan 2024 14:32:00 +0900, Michael Paquier wrote in > On Tue, Jan 16, 2024 at 02:46:02PM +0300, Aleksander Alekseev wrote: > >> For now, let me explain the basis for this patch. The fundamental > >> issue is that these warnings that always appear are, in practice, not > >> a problem in

Re: Make mesage at end-of-recovery less scary.

At Mon, 22 Jan 2024 16:09:28 +1100, Peter Smith wrote in > 2024-01 Commitfest. > > Hi, This patch has a CF status of "Needs Review" [1], but it seems > there were CFbot test failures last time it was run [2]. Please have a > look and post an updated version if necessary. > > == > [1] https

Re: Make mesage at end-of-recovery less scary.

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/2490/ [2] https://cirrus-ci.com/github/postg

Re: Make mesage at end-of-recovery less scary.

On Tue, Jan 16, 2024 at 02:46:02PM +0300, Aleksander Alekseev wrote: >> For now, let me explain the basis for this patch. The fundamental >> issue is that these warnings that always appear are, in practice, not >> a problem in almost all cases. Some of those who encounter them for >> the first time

Re: Make mesage at end-of-recovery less scary.

Hi, > > If I understand correctly, if somehow several FS blocks end up being > > zeroed (due to OS bug, bit rot, restoring from a corrupted for > > whatever reason backup, hardware failures, ...) there is non-zero > > chance that PG will interpret this as a normal situation. To my > > knowledge th

Re: Make mesage at end-of-recovery less scary.

Thank you for the comments. At Fri, 12 Jan 2024 15:03:26 +0300, Aleksander Alekseev wrote in > ``` > +p = (char *) record; > +pe = p + XLOG_BLCKSZ - (RecPtr & (XLOG_BLCKSZ - 1)); > + > +while (p < pe && *p == 0) > +p++; > + > +if (p == pe) > ``` > >

Re: Make mesage at end-of-recovery less scary.

Hi, > The errors occurred in a part of the tests for end-of-WAL detection > added in the master branch. These failures were primarily due to > changes in the message contents introduced by this patch. During the > revision, I discovered an issue with the handling of empty pages that > appear in th

Re: Make mesage at end-of-recovery less scary.

At Fri, 5 Jan 2024 16:02:24 +0530, vignesh C wrote in > On Wed, 22 Nov 2023 at 13:01, Kyotaro Horiguchi > wrote: > > > > Anyway, this requires rebsaing, and done. > > Few tests are failing at [1], kindly post an updated patch: Thanks! The errors occurred in a part of the tests for end-of-WAL

Re: Make mesage at end-of-recovery less scary.

On Wed, 22 Nov 2023 at 13:01, Kyotaro Horiguchi wrote: > > Anyway, this requires rebsaing, and done. Few tests are failing at [1], kindly post an updated patch: /tmp/cirrus-ci-build/src/test/recovery --testgroup recovery --testname 039_end_of_wal -- /usr/local/bin/perl -I /tmp/cirrus-ci-build/src

Re: Make mesage at end-of-recovery less scary.

Anyway, this requires rebsaing, and done. Thanks for John (Naylor) for pointing this out. regards. -- Kyotaro Horiguchi NTT Open Source Software Center >From e56f1f24523e3e562a4db166dfeaadc79fd7b27a Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi Date: Tue, 7 Mar 2023 14:55:58 +0900 Subject:

Re: Make mesage at end-of-recovery less scary.

At Mon, 17 Jul 2023 15:20:30 +0300, Aleksander Alekseev wrote in > Thanks for working on this, it bugged me for a while. I noticed that > cfbot is not happy with the patch so I rebased it. > postgresql:pg_waldump test suite didn't pass after the rebase. I fixed > it too. Other than that the patc

Re: Make mesage at end-of-recovery less scary.

Hi, > Thanks for checking it! > > I think 4ac30ba4f2 is that, which changes a few error > messages. Addition to rebasing, I rewrote some code comments of > xlogreader.c and revised the additional test script. Thanks for working on this, it bugged me for a while. I noticed that cfbot is not happy

Re: Make mesage at end-of-recovery less scary.

At Mon, 6 Mar 2023 14:58:15 -0500, "Gregory Stark (as CFM)" wrote in > It looks like this needs a rebase and at a quick glance it looks like > more than a trivial conflict. I'll mark it Waiting on Author. Please > update it back when it's rebased Thanks for checking it! I think 4ac30ba4f2 is t

Re: Make mesage at end-of-recovery less scary.

It looks like this needs a rebase and at a quick glance it looks like more than a trivial conflict. I'll mark it Waiting on Author. Please update it back when it's rebased -- Gregory Stark As Commitfest Manager

Re: Make mesage at end-of-recovery less scary.

Thanks! At Fri, 3 Feb 2023 15:16:02 +0100, Alvaro Herrera wrote in > So this patch is now failing because it applies new tests to > 011_crash_recovery.pl, which was removed recently. Can you please move > them elsewhere? I don't find an appropriate file to move to. In the end I created a new

Re: Make mesage at end-of-recovery less scary.

So this patch is now failing because it applies new tests to 011_crash_recovery.pl, which was removed recently. Can you please move them elsewhere? I think the comment for ValidXLogRecordLength should explain what the return value is. -- Álvaro HerreraBreisgau, Deutschland — https://w

Re: Make mesage at end-of-recovery less scary.

At Tue, 22 Nov 2022 16:04:56 -0600, Justin Pryzby wrote in > On Fri, Nov 18, 2022 at 05:25:37PM +0900, Kyotaro Horiguchi wrote: > > + while (*p == 0 && p < pe) > > + p++; > > The bug reported by Andres/cfbot/ubsan is here. > > Fixed in attached. Ur..ou.. -

Re: Make mesage at end-of-recovery less scary.

On Fri, Nov 18, 2022 at 05:25:37PM +0900, Kyotaro Horiguchi wrote: > + while (*p == 0 && p < pe) > + p++; The bug reported by Andres/cfbot/ubsan is here. Fixed in attached. I didn't try to patch the test case to output the failing stderr, but that might be good. >

Re: Make mesage at end-of-recovery less scary.

Hi, On 2022-11-18 17:25:37 +0900, Kyotaro Horiguchi wrote: > Just rebased. Fails with address sanitizer: https://cirrus-ci.com/task/5632986241564672 Unfortunately one of the failures is in pg_waldump and we don't seem to capture its output in 011_crash_recovery. So we don't see the nice formattt

Re: Make mesage at end-of-recovery less scary.

Just rebased. regards. -- Kyotaro Horiguchi NTT Open Source Software Center >From 1efe0601596807c25769370f38884c7027a00839 Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi Date: Tue, 15 Nov 2022 13:41:46 +0900 Subject: [PATCH v22] Make End-Of-Recovery error less scary When recovery in any type

Re: Make mesage at end-of-recovery less scary.

rebased >From 67ce65038ae6a7d5b023b7472df9f9ca9835d5f5 Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi Date: Thu, 7 Jul 2022 11:51:45 +0900 Subject: [PATCH] Make End-Of-Recovery error less scary When recovery in any type ends, we see a bit scary error message like "invalid record length" that su

Re: Make mesage at end-of-recovery less scary.

At Fri, 16 Sep 2022 23:21:50 -0500, Justin Pryzby wrote in > @cfbot: rebased over adb466150, which did the same thing as one of the > hunks in xlogreader.c. Oops. Thanks! And then this gets a further conflict (param names harmonization). So further rebased. And removed an extra blank line you

Re: Make mesage at end-of-recovery less scary.

@cfbot: rebased over adb466150, which did the same thing as one of the hunks in xlogreader.c. >From c4069bb7181b68d742d2025567f859e69d24f513 Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi Date: Thu, 7 Jul 2022 11:51:45 +0900 Subject: [PATCH] Make End-Of-Recovery error less scary When recovery i

Re: Make mesage at end-of-recovery less scary.

At Wed, 6 Jul 2022 11:05:51 -0700, Jacob Champion wrote in > On Mon, Mar 28, 2022 at 11:07 PM Kyotaro Horiguchi > wrote: > > > > Rebased. > > Unfortunately this will need another rebase over latest. Thanks! Done. regards. -- Kyotaro Horiguchi NTT Open Source Software Center >From ff8a069c

Re: Make mesage at end-of-recovery less scary.

On Wed, Jul 06, 2022 at 11:05:51AM -0700, Jacob Champion wrote: > [CFM hat] Looking through the history here, this has been bumped to > Ready for Committer a few times and then bumped back to Needs Review > after a required rebase. What's the best way for us to provide support > for contributors wh

Re: Make mesage at end-of-recovery less scary.

On Mon, Mar 28, 2022 at 11:07 PM Kyotaro Horiguchi wrote: > > Rebased. Unfortunately this will need another rebase over latest. [CFM hat] Looking through the history here, this has been bumped to Ready for Committer a few times and then bumped back to Needs Review after a required rebase. What's

Re: Make mesage at end-of-recovery less scary.

me> Rebased to the current HEAD. b64c3bd62e (removal of unused "use Config") conflicted on a TAP script. Rebased. -- Kyotaro Horiguchi NTT Open Source Software Center >From e1492816913efcb4fc25ee6a3bafd27a6c5f3f9a Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi Date: Fri, 28 Feb 2020 15:52:58

Re: Make mesage at end-of-recovery less scary.

At Mon, 21 Mar 2022 17:01:19 -0700, Andres Freund wrote in > Patch currently fails to apply, needs a rebase: > http://cfbot.cputube.org/patch_37_2490.log Thanks for noticing me of that. Rebased to the current HEAD. regards. -- Kyotaro Horiguchi NTT Open Source Software Center >From a7c9f36e6

Re: Make mesage at end-of-recovery less scary.

Hi, On 2022-03-04 09:43:59 +0900, Kyotaro Horiguchi wrote: > On second thought the two seems repeating the same things. Thus I > merged the two comments together. In this verion 16 it looks like > this. Patch currently fails to apply, needs a rebase: http://cfbot.cputube.org/patch_37_2490.log

Re: Make mesage at end-of-recovery less scary.

At Thu, 3 Mar 2022 15:39:44 +0530, Ashutosh Sharma wrote in > The new changes made in the patch look good. Thanks to the recent > changes to speed WAL insertion that have helped us catch this bug. Thanks for the quick checking. > One small comment: > > record = (XLogRecord *) (state->

Re: Make mesage at end-of-recovery less scary.

On Wed, Mar 2, 2022 at 7:47 AM Kyotaro Horiguchi wrote: > > At Sat, 19 Feb 2022 09:31:33 +0530, Ashutosh Sharma > wrote in > > The changes looks good. thanks.! > > Thanks! > > Some recent core change changed WAL insertion speed during the TAP > test and revealed one forgotton case of EndOfWAL.

Re: Make mesage at end-of-recovery less scary.

At Sat, 19 Feb 2022 09:31:33 +0530, Ashutosh Sharma wrote in > The changes looks good. thanks.! Thanks! Some recent core change changed WAL insertion speed during the TAP test and revealed one forgotton case of EndOfWAL. When a record header flows into the next page, XLogReadRecord does separ

Re: Make mesage at end-of-recovery less scary.

On Thu, Feb 17, 2022 at 1:20 PM Kyotaro Horiguchi wrote: > > At Tue, 15 Feb 2022 20:17:20 +0530, Ashutosh Sharma > wrote in > > OK. The v13 patch looks good. I have marked it as ready to commit. > > Thank you for working on all my review comments. > > Thaks! But the recent xlog.c refactoring cra

Re: Make mesage at end-of-recovery less scary.

On Thu, Feb 17, 2022 at 1:20 PM Kyotaro Horiguchi wrote: > > At Tue, 15 Feb 2022 20:17:20 +0530, Ashutosh Sharma > wrote in > > OK. The v13 patch looks good. I have marked it as ready to commit. > > Thank you for working on all my review comments. > > Thaks! But the recent xlog.c refactoring cra

Re: Make mesage at end-of-recovery less scary.

At Tue, 15 Feb 2022 20:17:20 +0530, Ashutosh Sharma wrote in > OK. The v13 patch looks good. I have marked it as ready to commit. > Thank you for working on all my review comments. Thaks! But the recent xlog.c refactoring crashes into this patch. And I found a silly bug while rebasing. xlog.c:

Re: Make mesage at end-of-recovery less scary.

On Tue, Feb 15, 2022 at 7:52 AM Kyotaro Horiguchi wrote: > > At Mon, 14 Feb 2022 20:14:11 +0530, Ashutosh Sharma > wrote in > > No, I haven't tried to compare archive recovery to PITR or vice versa, > > instead I was trying to compare crash recovery with PITR. The message > > you're emitting say

Re: Make mesage at end-of-recovery less scary.

At Mon, 14 Feb 2022 20:14:11 +0530, Ashutosh Sharma wrote in > No, I haven't tried to compare archive recovery to PITR or vice versa, > instead I was trying to compare crash recovery with PITR. The message > you're emitting says just before entering into the archive recovery is > - "reached end-

Re: Make mesage at end-of-recovery less scary.

Hi, On Thu, Feb 10, 2022 at 11:47 AM Kyotaro Horiguchi wrote: > > At Wed, 9 Feb 2022 17:31:02 +0530, Ashutosh Sharma > wrote in > > On Wed, Feb 9, 2022 at 1:14 PM Kyotaro Horiguchi > > wrote: > > > This means archive-recovery is requested but not started yet. That is, > > > we've just finished

Re: Make mesage at end-of-recovery less scary.

At Wed, 9 Feb 2022 17:31:02 +0530, Ashutosh Sharma wrote in > On Wed, Feb 9, 2022 at 1:14 PM Kyotaro Horiguchi > wrote: > > This means archive-recovery is requested but not started yet. That is, > > we've just finished crash recovery. The existing comment cited > > together is mentioning that.

Re: Make mesage at end-of-recovery less scary.

On Wed, Feb 9, 2022 at 1:14 PM Kyotaro Horiguchi wrote: > > Hi, Ashutosh. > > At Tue, 8 Feb 2022 18:35:34 +0530, Ashutosh Sharma > wrote in > > Here are some of my review comments on the v11 patch: > > Thank you for taking a look on this. > > > - (errmsg_internal("reached e

Re: Make mesage at end-of-recovery less scary.

Hi, Ashutosh. At Tue, 8 Feb 2022 18:35:34 +0530, Ashutosh Sharma wrote in > Here are some of my review comments on the v11 patch: Thank you for taking a look on this. > - (errmsg_internal("reached end of WAL in > pg_wal, entering archive recovery"))); > +

Re: Make mesage at end-of-recovery less scary.

Hi, Here are some of my review comments on the v11 patch: - (errmsg_internal("reached end of WAL in pg_wal, entering archive recovery"))); + (errmsg_internal("reached end of WAL at %X/%X on timeline %u in %s during crash recovery, entering archive recov

Re: Make mesage at end-of-recovery less scary.

> > Thanks! The suggested change is done in the attached v11. > Thanks! v11 is a small refactoring of v10 that doesn't change behavior, so it is RfC as well. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com

Re: Make mesage at end-of-recovery less scary.

At Tue, 1 Feb 2022 12:38:01 +0400, Pavel Borisov wrote in > Maybe it can be written little bit shorter: > pe = (char *) record + XLOG_BLCKSZ - (RecPtr & (XLOG_BLCKSZ - 1)); > as > pe = p + XLOG_BLCKSZ - (RecPtr & (XLOG_BLCKSZ - 1)); > ? That difference would be a matter of taste, but I found it

Re: Make mesage at end-of-recovery less scary.

> > This version 10 is changed in the following points. > > - Rewrited the comment in ValidXLogRecordHeader. > - ValidXLogRecordHeader > Thanks! Maybe it can be written little bit shorter: pe = (char *) record + XLOG_BLCKSZ - (RecPtr & (XLOG_BLCKSZ - 1)); as pe = p + XLOG_BLCKSZ - (RecPtr & (XLOG_

Re: Make mesage at end-of-recovery less scary.

Hi, Pavel. At Mon, 31 Jan 2022 15:17:09 +0400, Pavel Borisov wrote in > I don't quite understand a meaning of a comment: > /* it is completely zeroed, call it a day */ While rethinking about this comment, It came to my mind that XLogReaderValidatePageHeader is doing whole-page check. There

Re: Make mesage at end-of-recovery less scary.

> > > This v8 is changed in... > > > > - Added tests to 011_crash_recovery.pl > > > > - Fixed a bug that server emits "end-of-wal" messages even if it have > > emitted an error message for the same LSN. > > > > - Changed XLogReaderValidatePageHeader() so that it recognizes an > > empty page as

Re: Make mesage at end-of-recovery less scary.

At Tue, 25 Jan 2022 17:34:56 +0900 (JST), Kyotaro Horiguchi wrote in > This v8 is changed in... > > - Added tests to 011_crash_recovery.pl > > - Fixed a bug that server emits "end-of-wal" messages even if it have > emitted an error message for the same LSN. > > - Changed XLogReaderValidateP

Re: Make mesage at end-of-recovery less scary.

At Mon, 24 Jan 2022 14:23:33 +0400, Pavel Borisov wrote in > > > > d2ddfa681db27a138acb63c8defa8cc6fa588922 removed global variables > > ReadRecPtr and EndRecPtr. This is rebased version that reads the LSNs > > directly from xlogreader instead of the removed global variables. > > > > Hi, hacker

Re: Make mesage at end-of-recovery less scary.

> > d2ddfa681db27a138acb63c8defa8cc6fa588922 removed global variables > ReadRecPtr and EndRecPtr. This is rebased version that reads the LSNs > directly from xlogreader instead of the removed global variables. > Hi, hackers! I've checked the latest version of a patch. It applies cleanly, check-wo

Re: Make mesage at end-of-recovery less scary.

At Tue, 09 Nov 2021 16:27:51 +0900 (JST), Kyotaro Horiguchi wrote in > This is the updated version. > > - emode_for_currupt_record() now uses currentSource instead of > readSource. > > - If zero record length is faced, make sure the whole header is zeroed > before deciding it as the end-of

Re: Make mesage at end-of-recovery less scary.

Thank you for the comments! At Tue, 9 Nov 2021 09:53:15 +0900, Michael Paquier wrote in > On Mon, Nov 08, 2021 at 02:59:46PM +0900, Kyotaro Horiguchi wrote: > > While checking the behavior for the case of missing-contrecord, I > > noticed that emode_for_corrupt_record() doesn't work as expected

Re: Make mesage at end-of-recovery less scary.

On Mon, Nov 08, 2021 at 02:59:46PM +0900, Kyotaro Horiguchi wrote: > While checking the behavior for the case of missing-contrecord, I > noticed that emode_for_corrupt_record() doesn't work as expected since > readSource is reset to XLOG_FROM_ANY after a read failure. We could > remember the last f

Re: Make mesage at end-of-recovery less scary.

At Fri, 22 Oct 2021 17:54:40 +, "Bossart, Nathan" wrote in > On 3/4/21, 10:50 PM, "Kyotaro Horiguchi" wrote: > > As the result, the following messages are emitted with the attached. > > I'd like to voice my support for this effort, and I intend to help > review the patch. It looks like th

Re: Make mesage at end-of-recovery less scary.

On 3/4/21, 10:50 PM, "Kyotaro Horiguchi" wrote: > As the result, the following messages are emitted with the attached. I'd like to voice my support for this effort, and I intend to help review the patch. It looks like the latest patch no longer applies, so I've marked the commitfest entry [0] as

Re: Make mesage at end-of-recovery less scary.

At Wed, 3 Mar 2021 11:14:20 -0500, David Steele wrote in > Hi Kyotaro, > > On 3/27/20 10:25 PM, James Coleman wrote: > > On Thu, Mar 26, 2020 at 12:41 PM Robert Haas > > wrote: > >> > >> I'm just spitballing here, but it would be really good if there's a > >> way to know definitely whether or n

Re: Make mesage at end-of-recovery less scary.

Hi Kyotaro, On 3/27/20 10:25 PM, James Coleman wrote: On Thu, Mar 26, 2020 at 12:41 PM Robert Haas wrote: I'm just spitballing here, but it would be really good if there's a way to know definitely whether or not you should be scared. Corrupted WAL segments are definitely a thing that happens,

Re: Make mesage at end-of-recovery less scary.

On Thu, Mar 26, 2020 at 12:41 PM Robert Haas wrote: > > On Wed, Mar 25, 2020 at 8:53 AM Peter Eisentraut > wrote: > > HINT: This is to be expected if this is the end of the WAL. Otherwise, > > it could indicate corruption. > > First, I agree that this general issue is a problem, because it's co

Re: Make mesage at end-of-recovery less scary.

On Wed, Mar 25, 2020 at 8:53 AM Peter Eisentraut wrote: > HINT: This is to be expected if this is the end of the WAL. Otherwise, > it could indicate corruption. First, I agree that this general issue is a problem, because it's come up for me in quite a number of customer situations. Either peop

Re: Make mesage at end-of-recovery less scary.

On 2020-03-24 02:52, Kyotaro Horiguchi wrote: I don't find that very satisfying, but I can't come up with something that provides the current information, while being less scary than my suggestion? The 0-length record is not an "invalid" state during recovery, so we can add the message for the s

Re: Make mesage at end-of-recovery less scary.

At Mon, 23 Mar 2020 12:47:36 -0700, Andres Freund wrote in > Hi, > > On 2020-03-23 10:37:16 +0100, Peter Eisentraut wrote: > > On 2020-03-05 08:06, Kyotaro Horiguchi wrote: > > > | [20866] LOG: replication terminated by primary server > > > | [20866] DETAIL: End of WAL reached on timeline 1 at

Re: Make mesage at end-of-recovery less scary.

Hi, On 2020-03-23 10:43:09 -0700, Ashwin Agrawal wrote: > Plus, I am hoping message will improve for pg_waldump as well? > Since it reads confusing and every-time have to explain new developer it's > expected behavior which is annoying. > > pg_waldump: fatal: error in WAL record at 0/1553F70: inv

Re: Make mesage at end-of-recovery less scary.

Hi, On 2020-03-23 10:37:16 +0100, Peter Eisentraut wrote: > On 2020-03-05 08:06, Kyotaro Horiguchi wrote: > > | [20866] LOG: replication terminated by primary server > > | [20866] DETAIL: End of WAL reached on timeline 1 at 0/30001C8. > > | [20866] FATAL: could not send end-of-streaming message

Re: Make mesage at end-of-recovery less scary.

On Mon, Mar 23, 2020 at 2:37 AM Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 2020-03-05 08:06, Kyotaro Horiguchi wrote: > > | [20866] LOG: replication terminated by primary server > > | [20866] DETAIL: End of WAL reached on timeline 1 at 0/30001C8. > > | [20866] FATAL: could

Re: Make mesage at end-of-recovery less scary.

On 2020-03-05 08:06, Kyotaro Horiguchi wrote: | [20866] LOG: replication terminated by primary server | [20866] DETAIL: End of WAL reached on timeline 1 at 0/30001C8. | [20866] FATAL: could not send end-of-streaming message to primary: no COPY in progress | [20851] LOG: reached end of WAL at

Re: Make mesage at end-of-recovery less scary.

Hello. I changed the condition from randAccess to fetching_ckpt considering the discussion in another thread [1]. Then I moved the block that shows the new messages to more appropriate place. At Fri, 28 Feb 2020 17:28:06 +0900 (JST), Kyotaro Horiguchi wrote in > > > > Have you considered an e

Re: Make mesage at end-of-recovery less scary.

Thank you for the comments. At Fri, 28 Feb 2020 16:33:18 +0900, Michael Paquier wrote in > On Fri, Feb 28, 2020 at 04:01:00PM +0900, Kyotaro Horiguchi wrote: > > Hello, this is a followup thread of [1]. > > > > # I didn't noticed that the thread didn't cover -hackers.. > > > > When recovery o

Re: Make mesage at end-of-recovery less scary.

On Fri, Feb 28, 2020 at 04:01:00PM +0900, Kyotaro Horiguchi wrote: > Hello, this is a followup thread of [1]. > > # I didn't noticed that the thread didn't cover -hackers.. > > When recovery of any type ends, we see several kinds of error messages > that says "WAL is broken". Have you considered

Make mesage at end-of-recovery less scary.

Hello, this is a followup thread of [1]. # I didn't noticed that the thread didn't cover -hackers.. When recovery of any type ends, we see several kinds of error messages that says "WAL is broken". > LOG: invalid record length at 0/7CB6BC8: wanted 24, got 0 > LOG: redo is not required > LOG: