Hi Kyotaro,
On 3/27/20 10:25 PM, James Coleman wrote:
On Thu, Mar 26, 2020 at 12:41 PM Robert Haas <robertmh...@gmail.com> wrote:
I'm just spitballing here, but it would be really good if there's a
way to know definitely whether or not you should be scared. Corrupted
WAL segments are definitely a thing that happens, but retries are a
lot more common.
First, I agree that getting enough context to say precisely is by far the ideal.
That being said, as an end user who's found this surprising -- and
momentarily scary every time I initially scan it even though I *know
intellectually it's not* -- I would find Peter's suggestion a
significant improvement over what we have now. I'm fairly certainly my
co-workers on our database team would also. Knowing that something is
at least not always scary is good. Though I'll grant that this does
have the negative in reverse: if it actually is a scary
situation...this mutes your concern level. On the other hand,
monitoring would tell us if there's a real problem (namely replication
lag), so I think the trade-off is clearly worth it.
How about this minor tweak:
HINT: This is expected if this is the end of currently available WAL.
Otherwise, it could indicate corruption.
Any thoughts on the suggestions for making the messaging clearer?
Also, the patch no longer applies:
http://cfbot.cputube.org/patch_32_2490.log.
Marking this Waiting on Author.
Regards,
--
-David
da...@pgmasters.net
