Re: Make all Perl warnings fatal

2024-10-29 Thread Peter Eisentraut
On 22.10.24 11:25, Anton Voloshin wrote: Hello, On 18/01/2024 10:52, Peter Eisentraut wrote: > Committed, thanks. since this patch two .pl files without FATAL in "use warnings" have been committed to master: src/test/recovery/t/043_wal_replay_wait.pl src/test/modules/test_misc/t/006_signal_a

Re: Make all Perl warnings fatal

2024-10-22 Thread Alexander Korotkov
Hi! On Tue, Oct 22, 2024 at 12:26 PM Anton Voloshin wrote: > On 18/01/2024 10:52, Peter Eisentraut wrote: > > Committed, thanks. > > since this patch two .pl files without FATAL in "use warnings" have been > committed to master: > src/test/recovery/t/043_wal_replay_wait.pl > src/test/modules/tes

Re: Make all Perl warnings fatal

2024-10-22 Thread Anton Voloshin
Hello, On 18/01/2024 10:52, Peter Eisentraut wrote: > Committed, thanks. since this patch two .pl files without FATAL in "use warnings" have been committed to master: src/test/recovery/t/043_wal_replay_wait.pl src/test/modules/test_misc/t/006_signal_autovacuum.pl They come from commit 06c418e

Re: Make all Perl warnings fatal

2024-01-17 Thread Peter Eisentraut
On 16.01.24 12:08, Bharath Rupireddy wrote: On Fri, Jan 12, 2024 at 9:21 PM Bharath Rupireddy wrote: On Fri, Jan 12, 2024 at 9:03 PM Peter Eisentraut wrote: I would put this code my $core = $ret & 128 ? " (core dumped)" : ""; die "psql exited with signal " . ($ret & 127

Re: Make all Perl warnings fatal

2024-01-16 Thread Bharath Rupireddy
On Fri, Jan 12, 2024 at 9:21 PM Bharath Rupireddy wrote: > > On Fri, Jan 12, 2024 at 9:03 PM Peter Eisentraut wrote: > > > > I would put this code > > > > my $core = $ret & 128 ? " (core dumped)" : ""; > > die "psql exited with signal " > >. ($ret & 127) > >. "$core: '$$

Re: Make all Perl warnings fatal

2024-01-12 Thread Bharath Rupireddy
On Fri, Jan 12, 2024 at 9:03 PM Peter Eisentraut wrote: > > On 11.01.24 12:29, Bharath Rupireddy wrote: > > On Sat, Dec 30, 2023 at 12:57 AM Peter Eisentraut > > wrote: > >> > >> committed > > > > With the commit c5385929 converting perl warnings to FATAL, use of > > psql/safe_psql with timeout

Re: Make all Perl warnings fatal

2024-01-12 Thread Peter Eisentraut
On 11.01.24 12:29, Bharath Rupireddy wrote: On Sat, Dec 30, 2023 at 12:57 AM Peter Eisentraut wrote: committed With the commit c5385929 converting perl warnings to FATAL, use of psql/safe_psql with timeout parameters [1] fail with the following error: Use of uninitialized value $ret in bitw

Re: Make all Perl warnings fatal

2024-01-11 Thread Bharath Rupireddy
On Sat, Dec 30, 2023 at 12:57 AM Peter Eisentraut wrote: > > committed With the commit c5385929 converting perl warnings to FATAL, use of psql/safe_psql with timeout parameters [1] fail with the following error: Use of uninitialized value $ret in bitwise and (&) at /home/ubuntu/postgres/src/test

Re: Make all Perl warnings fatal

2023-12-29 Thread Peter Eisentraut
On 22.12.23 22:33, Peter Eisentraut wrote: On 12.09.23 07:42, Peter Eisentraut wrote: On 10.08.23 07:58, Peter Eisentraut wrote: There are also a couple of issues in the MSVC legacy build system that would need to be tightened up in order to survive with fatal Perl warnings.  Obviously, there

Re: Make all Perl warnings fatal

2023-09-11 Thread Peter Eisentraut
On 10.08.23 07:58, Peter Eisentraut wrote: There are also a couple of issues in the MSVC legacy build system that would need to be tightened up in order to survive with fatal Perl warnings.  Obviously, there is a question whether it's worth spending any time on that anymore. It looks like the

Re: Make all Perl warnings fatal

2023-08-27 Thread Andrew Dunstan
On 2023-08-25 Fr 16:49, Dagfinn Ilmari Mannsåker wrote: Alvaro Herrera writes: On 2023-Aug-10, Peter Eisentraut wrote: I wanted to figure put if we can catch these more reliably, in the style of -Werror. AFAICT, there is no way to automatically turn all warnings into fatal errors. But the

Re: Make all Perl warnings fatal

2023-08-25 Thread Dagfinn Ilmari Mannsåker
Alvaro Herrera writes: > On 2023-Aug-10, Peter Eisentraut wrote: > >> I wanted to figure put if we can catch these more reliably, in the style of >> -Werror. AFAICT, there is no way to automatically turn all warnings into >> fatal errors. But there is a way to do it per script, by replacing >>

Re: Make all Perl warnings fatal

2023-08-23 Thread Peter Eisentraut
On 21.08.23 17:51, Andrew Dunstan wrote: Still, I guess that might not matter too much since apart from plperl we only use perl for building / testing. Regarding the dangers mentioned, I guess we can undo it if it proves a nuisance. +1 to getting rid if the unnecessary call to getprotobyname

Re: Make all Perl warnings fatal

2023-08-22 Thread Andrew Dunstan
On 2023-08-22 Tu 09:20, Alvaro Herrera wrote: On 2023-Aug-10, Peter Eisentraut wrote: I wanted to figure put if we can catch these more reliably, in the style of -Werror. AFAICT, there is no way to automatically turn all warnings into fatal errors. But there is a way to do it per script, by

Re: Make all Perl warnings fatal

2023-08-22 Thread Alvaro Herrera
On 2023-Aug-10, Peter Eisentraut wrote: > I wanted to figure put if we can catch these more reliably, in the style of > -Werror. AFAICT, there is no way to automatically turn all warnings into > fatal errors. But there is a way to do it per script, by replacing > > use warnings; > > by >

Re: Make all Perl warnings fatal

2023-08-22 Thread Andrew Dunstan
On 2023-08-22 Tu 00:05, Michael Paquier wrote: On Mon, Aug 21, 2023 at 11:51:24AM -0400, Andrew Dunstan wrote: It's not really the same as -Werror, because many warnings can be generated at runtime rather than compile-time. Still, I guess that might not matter too much since apart from plperl

Re: Make all Perl warnings fatal

2023-08-21 Thread Michael Paquier
On Mon, Aug 21, 2023 at 11:51:24AM -0400, Andrew Dunstan wrote: > It's not really the same as -Werror, because many warnings can be generated > at runtime rather than compile-time. > > Still, I guess that might not matter too much since apart from plperl we > only use perl for building / testing.

Re: Make all Perl warnings fatal

2023-08-21 Thread Andrew Dunstan
On 2023-08-21 Mo 02:20, Peter Eisentraut wrote: To avoid a complete bloodbath on cfbot, here is an updated patch set that includes a workaround for the getprotobyname() issue mentioned below. On 10.08.23 07:58, Peter Eisentraut wrote: We have a lot of Perl scripts in the tree, mostly code ge