On Sun, Mar 21, 2021 at 05:53:04PM +0530, Bharath Rupireddy wrote:
> +1 from me. So, after every call to test_access, the node's current
> logfile gets truncated and we don't need the logging collector process
> to step in for rotation of the logfile.
>
> The patch looks good to me and the kerber
Greetings,
* Michael Paquier (mich...@paquier.xyz) wrote:
> On Sat, Mar 20, 2021 at 05:37:47PM +0900, Michael Paquier wrote:
> > It seems to me that this would make the tests faster, that the test
> > would not need to wait for the logging collector and that the code
> > could just use slurp_file(
On Sat, Mar 20, 2021 at 4:59 PM Michael Paquier wrote:
>
> On Sat, Mar 20, 2021 at 05:37:47PM +0900, Michael Paquier wrote:
> > It seems to me that this would make the tests faster, that the test
> > would not need to wait for the logging collector and that the code
> > could just use slurp_file($
On Sat, Mar 20, 2021 at 05:37:47PM +0900, Michael Paquier wrote:
> It seems to me that this would make the tests faster, that the test
> would not need to wait for the logging collector and that the code
> could just use slurp_file($node->logfile) to get the data it wants to
> check for a given pat
On Wed, Dec 02, 2020 at 02:44:31PM -0500, Stephen Frost wrote:
> And committed.
This has been committed as of dc11f31a, that changed the configuration
of the node in the kerberos test to use logging_collector. Wouldn't
it be simpler to not use the logging collector here and use a logic
similar to
Greetings,
* Stephen Frost (sfr...@snowman.net) wrote:
> * vignesh C (vignes...@gmail.com) wrote:
> > Thanks for testing this, I had missed testing this. The expression
> > matching was not correct. Attached v6 patch which includes the fix for
> > this.
>
> This generally looks pretty good to me.
Greetings,
* vignesh C (vignes...@gmail.com) wrote:
> Thanks for testing this, I had missed testing this. The expression
> matching was not correct. Attached v6 patch which includes the fix for
> this.
This generally looks pretty good to me. I did reword the commit message
a bit, run pgindent, a
On Sat, Nov 7, 2020 at 9:27 AM vignesh C wrote:
>
> Yes the test will fail if it takes more than the max_attempts as there
> is a like statement immediately after the loop:
> like($first_logfile, qr/\Q$expect_log_msg\E/,
> 'found expected log file content')
On Thu, Nov 5, 2020 at 9:50 AM Bharath Rupireddy
wrote:
>
> On Thu, Nov 5, 2020 at 7:55 AM Euler Taveira
> wrote:
> >
> > No. Don't worry with translations during the development. Make sure to
> > follow
> > the instructions provided here [1]. Translations are coordinated in a
> > different
>
On Thu, Nov 5, 2020 at 7:55 AM Euler Taveira
wrote:
>
> No. Don't worry with translations during the development. Make sure to
follow
> the instructions provided here [1]. Translations are coordinated in a
different
> mailing list: pgsql-translators [2]. There is a different repository [3]
for
> h
On Wed, 4 Nov 2020 at 22:52, Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
> On Tue, Nov 3, 2020 at 12:49 PM vignesh C wrote:
>
> 1. Do we need to generate and add the translation of the new GSS
> message in all the language specific files under po/ directory?. See
> below fo
On Tue, Nov 3, 2020 at 12:49 PM vignesh C wrote:
>
> Thanks for the explanation, I have attached a v5 patch with the
> changes where the translation should not have any problem.
>
I took a look at the V5 patch. Below are some comments:
1. Do we need to generate and add the translation of the new
On Sun, Nov 1, 2020 at 3:34 AM Euler Taveira
wrote:
>
> On Sat, 31 Oct 2020 at 00:34, Bharath Rupireddy
> wrote:
>>
>> On Fri, Oct 30, 2020 at 6:35 PM Euler Taveira
>> wrote:
>> >
>> > + appendStringInfo(&logmsg, "replication ");
>> > +
>> > + appendStringInfo(&logmsg, "connection authorized: u
On Sun, Nov 1, 2020 at 3:34 AM Euler Taveira
wrote:
>
> No. The strings are specified in the appendStringInfo, hence you should add
> _()
> around the string to be translated. There is nothing to be translated if you
> specify only the format identifier. You can always test if gettext extracts
>
On Sat, 31 Oct 2020 at 00:34, Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
> On Fri, Oct 30, 2020 at 6:35 PM Euler Taveira
> wrote:
> >
> > + appendStringInfo(&logmsg, "replication ");
> > +
> > + appendStringInfo(&logmsg, "connection authorized: user=%s",
> > + port->user_n
Thanks for the comments Bharath.
On Sat, Oct 31, 2020 at 10:18 AM Bharath Rupireddy
wrote:
>
> I took a look at v3 patch. Here are some comments.
>
> 1. Why are the input strings(not the newly added GSS log message
> string) to test_access() function are in some places double-quoted and
> in some
On Fri, Oct 30, 2020 at 6:13 PM vignesh C wrote:
>
> I have added the log validation to the existing tests that are present
> for authentication.
>
I took a look at v3 patch. Here are some comments.
1. Why are the input strings(not the newly added GSS log message
string) to test_access() functio
On Sat, Oct 31, 2020 at 9:04 AM Bharath Rupireddy
wrote:
>
> > +$node->append_conf('postgresql.conf', "logging_collector= 'on'");
> > +$node->append_conf('postgresql.conf', "log_connections= 'on'");
> >
> > booleans don't need quotes.
> >
>
> I think that's not correct. If I'm right, the snippet p
On Fri, Oct 30, 2020 at 6:35 PM Euler Taveira
wrote:
>
> + appendStringInfo(&logmsg, "replication ");
> +
> + appendStringInfo(&logmsg, "connection authorized: user=%s",
> + port->user_name);
> + if (!am_walsender)
> + appendStringInfo(&logmsg, " database=%s", port->database_name);
> +
> + if (por
On Fri, 30 Oct 2020 at 09:43, vignesh C wrote:
>
> Attached v3 patch has the change for the same.
>
>
Hi Vignesh,
+ appendStringInfo(&logmsg, "replication ");
+
+ appendStringInfo(&logmsg, "connection authorized: user=%s",
+ port->user_name);
+ if (!am_walsender)
+ appendStringInfo(&logmsg, " da
Thanks for the comments Bharath.
On Thu, Oct 29, 2020 at 12:15 PM Bharath Rupireddy
wrote:
> 1. Instead of just "on/off" after GSS %s in the log message, wouldn't it be
> informative if we have authenticated and/or encrypted as suggested by Stephen?
>
> So the log message would look like this:
>
08e29a92 Mon Sep 17 00:00:00 2001
> > From: Vignesh C
> > Date: Wed, 28 Oct 2020 08:19:06 +0530
> > Subject: [PATCH v2] Log message for GSS connection is missing once
> > connection
> > authorization is successful.
> >
> > Log message for GSS connection
08:19:06 +0530
> Subject: [PATCH v2] Log message for GSS connection is missing once connection
> authorization is successful.
>
> Log message for GSS connection is missing once connection authorization is
> successful. We have similar log message for SSL connections once the
> connect
Please add this to commitfest to not lose track of it.
I took a look at v2 patch, here are some comments.
On Thu, Oct 29, 2020 at 11:01 AM vignesh C wrote:
>
> Stephen also shared his thoughts for the above changes, I have
> provided an updated patch for the same in the previous mail. Please
> h
Thanks Bharath for your comments.
On Wed, Oct 28, 2020 at 9:48 AM Bharath Rupireddy
wrote:
>
> On Wed, Oct 28, 2020 at 8:29 AM vignesh C wrote:
> >
> > Log message for GSS connection is missing once connection
> > authorization is successful. We have similar log messages
Thanks Stephen for your comments.
On Wed, Oct 28, 2020 at 9:44 PM Stephen Frost wrote:
>
> Greetings,
>
> * vignesh C (vignes...@gmail.com) wrote:
> > Log message for GSS connection is missing once connection
> > authorization is successful. We have similar log messages
Greetings,
* vignesh C (vignes...@gmail.com) wrote:
> Log message for GSS connection is missing once connection
> authorization is successful. We have similar log messages for SSL
> connections once the connection authorization is successful. This
> message will help the user to
On Wed, Oct 28, 2020 at 8:29 AM vignesh C wrote:
>
> Log message for GSS connection is missing once connection
> authorization is successful. We have similar log messages for SSL
> connections once the connection authorization is successful. This
> message will help the user
Hi,
Log message for GSS connection is missing once connection
authorization is successful. We have similar log messages for SSL
connections once the connection authorization is successful. This
message will help the user to identify the connection that was
selected from the logfile. I'm not
29 matches
Mail list logo
