Re: Invalid "trailing junk" error message when non-English letters are used

2024-09-05 Thread Pavel Borisov
On Thu, 5 Sept 2024 at 20:49, Tom Lane wrote: > Karina Litskevich writes: > > On Thu, Sep 5, 2024 at 6:07 PM Karina Litskevich > > wrote: > >> In v3 of the patch I grouped all the *_junk rules together and included > >> the suggested comment with a little added something. > > > Oops, I forgot t

Re: Invalid "trailing junk" error message when non-English letters are used

2024-09-05 Thread Tom Lane
Karina Litskevich writes: > On Thu, Sep 5, 2024 at 6:07 PM Karina Litskevich > wrote: >> In v3 of the patch I grouped all the *_junk rules together and included >> the suggested comment with a little added something. > Oops, I forgot to attach the patch, here it is. Pushed with a bit of further

Re: Invalid "trailing junk" error message when non-English letters are used

2024-09-05 Thread Karina Litskevich
On Thu, Sep 5, 2024 at 6:07 PM Karina Litskevich wrote: > In v3 of the patch I grouped all the *_junk rules together and included > the suggested comment with a little added something. Oops, I forgot to attach the patch, here it is. Best regards, Karina Litskevich Postgres Professional: http://

Re: Invalid "trailing junk" error message when non-English letters are used

2024-09-05 Thread Karina Litskevich
On Thu, Sep 5, 2024 at 1:52 AM Tom Lane wrote: > Karina Litskevich writes: > > I see the two solutions here: either move the rule for decinteger_junk > > below the rules for hexinteger_junk, octinteger_junk and bininteger_junk, > > or just use a single rule decinteger_junk for all these cases, si

Re: Invalid "trailing junk" error message when non-English letters are used

2024-09-04 Thread Tom Lane
Karina Litskevich writes: > I see the two solutions here: either move the rule for decinteger_junk > below the rules for hexinteger_junk, octinteger_junk and bininteger_junk, > or just use a single rule decinteger_junk for all these cases, since the > error message is the same anyway. I implemente

Re: Invalid "trailing junk" error message when non-English letters are used

2024-08-28 Thread Karina Litskevich
On Wed, Aug 28, 2024 at 12:06 AM Pavel Borisov wrote: > I see the following compile time warnings: > scan.l:1062: warning, rule cannot be matched > scan.l:1066: warning, rule cannot be matched > scan.l:1070: warning, rule cannot be matched > pgc.l:1030: warning, rule cannot be matched > pgc.l:103

Re: Invalid "trailing junk" error message when non-English letters are used

2024-08-27 Thread Pavel Borisov
Hi, Karina! On Tue, 27 Aug 2024 at 19:06, Karina Litskevich wrote: > Hi hackers, > > When error "trailing junk after numeric literal" occurs at a number > followed by a symbol that is presented by more than one byte, that symbol > in the error message is not displayed correctly. Instead of that

Invalid "trailing junk" error message when non-English letters are used

2024-08-27 Thread Karina Litskevich
Hi hackers, When error "trailing junk after numeric literal" occurs at a number followed by a symbol that is presented by more than one byte, that symbol in the error message is not displayed correctly. Instead of that symbol there is only its first byte. That makes the error message an invalid UT