On Thu, 5 Sept 2024 at 20:49, Tom Lane <t...@sss.pgh.pa.us> wrote: > Karina Litskevich <litskevichkar...@gmail.com> writes: > > On Thu, Sep 5, 2024 at 6:07 PM Karina Litskevich > > <litskevichkar...@gmail.com> wrote: > >> In v3 of the patch I grouped all the *_junk rules together and included > >> the suggested comment with a little added something. > > > Oops, I forgot to attach the patch, here it is. > > Pushed with a bit of further wordsmithing on the comment. > > I left out the proposed new test case "SELECT 1ä;". The trouble > with that is it'd introduce an encoding dependency into the test. > For example, it'd likely fail with some other error message in > a server encoding that lacks an equivalent to UTF8 "ä". While > we have methods for coping with such cases, it requires some > pushups, and I didn't see the value. The changes in existing > test case results are sufficient to show the patch does what > we want. > > Also, while the bug exists in v15, the patch didn't apply at all. > I got lazy and just did the minimal s/ident_start/identifier/ change > in that branch, instead of back-patching the cosmetic aspects. >
Good! Thank you! Pavel
