Re: Indicate anti-wraparound autovacuum in log_autovacuum_min_duration

2018-09-14 Thread Sergei Kornilov
> Thanks Sergei for the new version, pushed. Thank you! regards, Sergei

Re: Indicate anti-wraparound autovacuum in log_autovacuum_min_duration

2018-09-13 Thread Michael Paquier
On Thu, Sep 13, 2018 at 12:00:49PM +0300, Sergei Kornilov wrote: > Looks better for me. Updated patch attached. Thanks Sergei for the new version, pushed. -- Michael signature.asc Description: PGP signature

Re: Indicate anti-wraparound autovacuum in log_autovacuum_min_duration

2018-09-13 Thread Sergei Kornilov
Hello > The brackets look rather useless to me, wouldn't it be better to remove > them? By doing so the longest message becomes: > "automatic aggressive vacuum to prevent wraparound of table blah.blah" Hmm, > 2018-09-13 11:48:09.303 MSK 6994 @ from [vxid:6/713 txid:0] [] LOG: > automatic aggre

Re: Indicate anti-wraparound autovacuum in log_autovacuum_min_duration

2018-09-12 Thread Michael Paquier
On Wed, Sep 12, 2018 at 05:36:31PM +0900, Masahiko Sawada wrote: > It would be useful if we have a number of the options autovacuum > workers could use but since there are only 2 I'm not sure we need the > list-style. Looking at what Sergei has proposed upthread again, using a comma-separated list

Re: Indicate anti-wraparound autovacuum in log_autovacuum_min_duration

2018-09-12 Thread Masahiko Sawada
On Tue, Jul 24, 2018 at 8:25 PM, Michael Paquier wrote: > On Tue, Jul 24, 2018 at 06:02:00PM +0900, Masahiko Sawada wrote: >> Yeah, for translation I think it's better to make full lines. When we >> added "aggressive" to autovacuum logs (commit b55509) we've done the >> same thing. > > I am wonde

Re: Indicate anti-wraparound autovacuum in log_autovacuum_min_duration

2018-07-24 Thread Michael Paquier
On Tue, Jul 24, 2018 at 06:02:00PM +0900, Masahiko Sawada wrote: > Yeah, for translation I think it's better to make full lines. When we > added "aggressive" to autovacuum logs (commit b55509) we've done the > same thing. I am wondering if it would easier to add an extra line in the output, like

Re: Indicate anti-wraparound autovacuum in log_autovacuum_min_duration

2018-07-24 Thread Masahiko Sawada
On Sat, Jul 21, 2018 at 6:26 PM, Sergei Kornilov wrote: > Hello > >> Yes, a bit more verbosity would be nice for that. Using the term >> "anti-wraparound" directly in the logs makes the most sense? > I used "(to prevent wraparound)" to looks like reporting in pg_stat_activity. > As far i can see

Re: Indicate anti-wraparound autovacuum in log_autovacuum_min_duration

2018-07-23 Thread Robert Haas
On Sat, Jul 21, 2018 at 4:22 AM, Michael Paquier wrote: > On Sat, Jul 21, 2018 at 09:38:38AM +0300, Sergei Kornilov wrote: >> Currently log_autovacuum_min_duration log message has no difference >> between regular autovacuum and to prevent wraparound autovacuum. There >> are important differences,

Re: Indicate anti-wraparound autovacuum in log_autovacuum_min_duration

2018-07-21 Thread Sergei Kornilov
Hello > Yes, a bit more verbosity would be nice for that. Using the term > "anti-wraparound" directly in the logs makes the most sense? I used "(to prevent wraparound)" to looks like reporting in pg_stat_activity. As far i can see currently we not using "anti-wraparound" for user messages. On the

Re: Indicate anti-wraparound autovacuum in log_autovacuum_min_duration

2018-07-21 Thread Michael Paquier
On Sat, Jul 21, 2018 at 09:38:38AM +0300, Sergei Kornilov wrote: > Currently log_autovacuum_min_duration log message has no difference > between regular autovacuum and to prevent wraparound autovacuum. There > are important differences, for example, backend can automatically > cancel regular autova

Indicate anti-wraparound autovacuum in log_autovacuum_min_duration

2018-07-20 Thread Sergei Kornilov
Hello Currently log_autovacuum_min_duration log message has no difference between regular autovacuum and to prevent wraparound autovacuum. There are important differences, for example, backend can automatically cancel regular autovacuum, but not anti-wraparound. I think it is useful indicate ant