Re: Inconsistent output handling in 002_pg_upgrade.pl test logs

2024-12-09 Thread Michael Paquier
On Mon, Oct 28, 2024 at 04:44:48PM +0100, Joel Jacobson wrote: > On Mon, Oct 28, 2024, at 13:44, Daniel Gustafsson wrote: >>> On 28 Oct 2024, at 13:38, Joel Jacobson wrote: >>> Option 1: Keep output together using note >> >>> Option 2: Adjust header message for separate logs >> >>> Thoughts on the

Inconsistent output handling in 002_pg_upgrade.pl test logs

2024-10-28 Thread Joel Jacobson
Hi hackers, I've noticed some inconsistency in 002_pg_upgrade.pl in how it handles output during test failures. Currently, it uses note to print the header: note "=== contents of $log ===\n"; but print for the log content and footer: print slurp_file($log); print "=== EOF ===\n"; T

Re: Inconsistent output handling in 002_pg_upgrade.pl test logs

2024-10-28 Thread Joel Jacobson
On Mon, Oct 28, 2024, at 13:44, Daniel Gustafsson wrote: >> On 28 Oct 2024, at 13:38, Joel Jacobson wrote: >> >> Hi hackers, >> >> I've noticed some inconsistency in 002_pg_upgrade.pl in how it handles output >> during test failures. Currently, it uses note to print the header: >> >>note "=

Re: Inconsistent output handling in 002_pg_upgrade.pl test logs

2024-10-28 Thread Daniel Gustafsson
> On 28 Oct 2024, at 13:38, Joel Jacobson wrote: > > Hi hackers, > > I've noticed some inconsistency in 002_pg_upgrade.pl in how it handles output > during test failures. Currently, it uses note to print the header: > >note "=== contents of $log ===\n"; > > but print for the log content an