On Mon, Oct 28, 2024, at 13:44, Daniel Gustafsson wrote: >> On 28 Oct 2024, at 13:38, Joel Jacobson <j...@compiler.org> wrote: >> >> Hi hackers, >> >> I've noticed some inconsistency in 002_pg_upgrade.pl in how it handles output >> during test failures. Currently, it uses note to print the header: >> >> note "=== contents of $log ===\n"; >> >> but print for the log content and footer: >> >> print slurp_file($log); >> print "=== EOF ===\n"; > > Ugh, nice catch. > >> Option 1: Keep output together using note > >> Option 2: Adjust header message for separate logs > >> Thoughts on these options? > > I would prefer to output this to the log only and not the TAP output, to avoid > the risk of not seeing the test output for all the log output on the screen.
I also think that's best, and in line with what we do in other parts of the same script. Patch attached. /Joel
0001-Fix-inconsistent-output-handling-in-002_pg_upgrade.p.patch
Description: Binary data
