At Fri, 11 Sep 2020 18:44:13 +1000, Peter Smith wrote
in
> On Thu, Sep 10, 2020 at 9:21 PM vignesh C wrote:
> > > Whether such a micro-optimisation is worth doing is another question.
> > Yes, what you suggested can also be done, but even I have the same
> > question as you. Because we will red
On Thu, Sep 10, 2020 at 9:21 PM vignesh C wrote:
> > Whether such a micro-optimisation is worth doing is another question.
> Yes, what you suggested can also be done, but even I have the same
> question as you. Because we will reduce just one function call, the
> eof check is present immediately i
At Thu, 10 Sep 2020 21:55:27 +0300, Surafel Temesgen
wrote in
> On Thu, Sep 10, 2020 at 1:17 PM vignesh C wrote:
>
> >
> > >
> > > We have a patch for column matching feature [1] that may need a header
> > line to be further processed. Even without that I think it is preferable to
> > process
On Thu, Sep 10, 2020 at 1:17 PM vignesh C wrote:
>
> >
> > We have a patch for column matching feature [1] that may need a header
> line to be further processed. Even without that I think it is preferable to
> process the header line for nothing than adding those checks to the loop,
> performance
On Wed, Sep 9, 2020 at 12:24 PM Peter Smith wrote:
>
> My basic understanding of first part of your patch is that by
> adjusting the "minread" it now allows it to loop multiple times
> internally within the CopyGetData rather than calling CopyLoadRawBuf
> for every N lines. There doesn't seem to b
On Mon, Sep 7, 2020 at 1:19 PM Surafel Temesgen wrote:
>
>
> Hi Vignesh
>
> On Wed, Jul 1, 2020 at 3:46 PM vignesh C wrote:
>>
>> Hi,
>>
>> While reviewing copy from I identified few improvements for copy from
>> that can be done :
>> a) copy from stdin copies lesser amount of data to buffer eve
My basic understanding of first part of your patch is that by
adjusting the "minread" it now allows it to loop multiple times
internally within the CopyGetData rather than calling CopyLoadRawBuf
for every N lines. There doesn't seem to be much change to what other
code gets executed so the saving i
Hi Vignesh
On Wed, Jul 1, 2020 at 3:46 PM vignesh C wrote:
> Hi,
>
> While reviewing copy from I identified few improvements for copy from
> that can be done :
> a) copy from stdin copies lesser amount of data to buffer even though
> space is available in buffer because minread was passed as 1
risedb.com
From a343fe1f8fdf4293d2ef6841e243390b99f29e28 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Sun, 30 Aug 2020 12:31:12 +0530
Subject: [PATCH v2] Improvements in copy from.
There are couple of improvements for copy from in this patch which is detailed
below:
a) copy from stdin copies lesser amount of data to buffer even
Hello.
FYI - that patch has conflicts when applied.
Kind Regards
Peter Smith
Fujitsu Australia.
On Thu, Aug 27, 2020 at 3:11 PM vignesh C wrote:
>
> On Tue, Jul 14, 2020 at 12:17 PM vignesh C wrote:
> >
> > On Tue, Jul 14, 2020 at 11:13 AM David Rowley wrote:
> > >
> > > On Tue, 14 Jul 2020 a
egards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
From fbafa5eaaa84028b3bbfb7cde0cbcc3963fd033a Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Tue, 14 Jul 2020 12:21:37 +0530
Subject: [PATCH] Improvements in copy from.
There are couple of improvements for copy from in this patch which
On Tue, Jul 14, 2020 at 11:13 AM David Rowley wrote:
>
> On Tue, 14 Jul 2020 at 17:22, David Rowley wrote:
> >
> > On Thu, 2 Jul 2020 at 00:46, vignesh C wrote:
> > > b) CopyMultiInsertInfoNextFreeSlot had an unused function parameter
> > > that is not being used, it can be removed.
> >
> > This
On Tue, 14 Jul 2020 at 17:22, David Rowley wrote:
>
> On Thu, 2 Jul 2020 at 00:46, vignesh C wrote:
> > b) CopyMultiInsertInfoNextFreeSlot had an unused function parameter
> > that is not being used, it can be removed.
>
> This was raised in [1]. We decided not to remove it.
I just added a comme
On Thu, 2 Jul 2020 at 00:46, vignesh C wrote:
> b) CopyMultiInsertInfoNextFreeSlot had an unused function parameter
> that is not being used, it can be removed.
This was raised in [1]. We decided not to remove it.
David
[1]
https://www.postgresql.org/message-id/flat/CAKJS1f-A5aYvPHe10Wy9LjC4Rz
On Wed, Jul 1, 2020 at 6:16 PM vignesh C wrote:
> Attached patch has the changes for the same.
> Thoughts?
>
Added a commitfest entry for this:
https://commitfest.postgresql.org/29/2642/
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
From: Vignesh C
Date: Wed, 1 Jul 2020 17:51:51 +0530
Subject: [PATCH] Improvements in copy from.
There are 3 improvements for copy from in this patch which is detailed below:
a) copy from stdin copies lesser amount of data to buffer even though space is
available in buffer because minread was passed as
16 matches
Mail list logo
