Re: Fix small typo, use InvalidRelFileNumber instead of InvalidOid

On Sat, Nov 9, 2024 at 12:41 PM Dilip Kumar wrote: > > On Fri, Nov 8, 2024 at 8:36 PM Tom Lane wrote: >> >> Dilip Kumar writes: >> > IIRC, In catalog we intentionally left it as Oid because RelFileNumber is >> > an internal typedef bug, it is not an exposed datatype, so probably we can >> > not

Re: Fix small typo, use InvalidRelFileNumber instead of InvalidOid

On Fri, Nov 8, 2024 at 8:36 PM Tom Lane wrote: > Dilip Kumar writes: > > IIRC, In catalog we intentionally left it as Oid because RelFileNumber is > > an internal typedef bug, it is not an exposed datatype, so probably we > can > > not use it in catalog. > > We could declare it as RelFileNumber

Re: Fix small typo, use InvalidRelFileNumber instead of InvalidOid

Dilip Kumar writes: > IIRC, In catalog we intentionally left it as Oid because RelFileNumber is > an internal typedef bug, it is not an exposed datatype, so probably we can > not use it in catalog. We could declare it as RelFileNumber so that that is what C code sees, and teach Catalog.pm to tran

Re: Fix small typo, use InvalidRelFileNumber instead of InvalidOid

On Fri, Nov 8, 2024 at 4:30 PM Alvaro Herrera wrote: > On 2024-Nov-08, Dilip Kumar wrote: > > > It appears that we are passing InvalidOid instead of InvalidRelFileNumber > > when calling index_create(). While this isn’t technically a bug, since > > InvalidRelFileNumber is defined as InvalidOid, i

Re: Fix small typo, use InvalidRelFileNumber instead of InvalidOid

On 2024-Nov-08, Dilip Kumar wrote: > It appears that we are passing InvalidOid instead of InvalidRelFileNumber > when calling index_create(). While this isn’t technically a bug, since > InvalidRelFileNumber is defined as InvalidOid, it’s preferable to use the > correct identifier for clarity and c

Re: Fix small typo, use InvalidRelFileNumber instead of InvalidOid

On Fri, Nov 8, 2024 at 3:17 PM Dilip Kumar wrote: > > It appears that we are passing InvalidOid instead of InvalidRelFileNumber > when calling index_create(). While this isn’t technically a bug, since > InvalidRelFileNumber is defined as InvalidOid, it’s preferable to use the > correct identifi

Fix small typo, use InvalidRelFileNumber instead of InvalidOid

It appears that we are passing InvalidOid instead of InvalidRelFileNumber when calling index_create(). While this isn’t technically a bug, since InvalidRelFileNumber is defined as InvalidOid, it’s preferable to use the correct identifier for clarity and consistency. -- Regards, Dilip Kumar Enterp