Re: Fix minor memory leak in connection string validation

2024-01-12 Thread Tom Lane
Nathan Bossart writes: > On Fri, Jan 12, 2024 at 03:06:26PM -0800, Jeff Davis wrote: >> It makes me wonder if we should use the resowner mechanism to track >> pointers to malloc'd memory. Then we could use a standard pattern for >> these kinds of cases, and it would also catch more remote issues,

Re: Fix minor memory leak in connection string validation

2024-01-12 Thread Nathan Bossart
On Fri, Jan 12, 2024 at 03:06:26PM -0800, Jeff Davis wrote: > It makes me wonder if we should use the resowner mechanism to track > pointers to malloc'd memory. Then we could use a standard pattern for > these kinds of cases, and it would also catch more remote issues, like > if a pstrdup() fails i

Fix minor memory leak in connection string validation

2024-01-12 Thread Jeff Davis
Introduced in commit c3afe8cf5a. Someone issuing repeated "CREATE SUBSCRIPTION" commands where the connection has no password and must_have_password is true will leak malloc'd memory in the error path. Minor issue in practice, because I suspect that a user privileged enough to create a subscriptio