Re: Feedback on table expansion hook (including patch)

2021-09-09 Thread Jaime Casanova
On Wed, May 12, 2021 at 10:19:17PM +0900, Amit Langote wrote: > (Sorry about being very late to this thread.) > > > Would it be unreasonable of us to ask for a worked-out example making > > use of the proposed hook? That'd go a long way towards resolving the > > question of whether you can do any

Re: Feedback on table expansion hook (including patch)

2021-05-12 Thread Amit Langote
(Sorry about being very late to this thread.) On Sun, Mar 7, 2021 at 3:09 AM Tom Lane wrote: > Peter Eisentraut writes: > > On 07.05.20 10:11, Erik Nordström wrote: > >> I am looking for feedback on the possibility of adding a table expansion > >> hook to PostgreSQL (see attached patch). > > > U

Re: Feedback on table expansion hook (including patch)

2021-05-12 Thread Julien Rouhaud
On Wed, May 12, 2021 at 04:48:29PM +0900, yuzuko wrote: > Hello, > > > Thank you all for the feedback and insights. > > > > Yes, the intention is to *replace* expand_inherited_rtentry() in the same > > way planner_hook replaces standard_planner(). > > > > This patch is really useful. We are wor

Re: Feedback on table expansion hook (including patch)

2021-05-12 Thread yuzuko
Hello, > Thank you all for the feedback and insights. > > Yes, the intention is to *replace* expand_inherited_rtentry() in the same way > planner_hook replaces standard_planner(). > This patch is really useful. We are working on developing hypothetical partitioning as a feature of HypoPG[1][2],

Re: Feedback on table expansion hook (including patch)

2021-05-11 Thread Aleksander Alekseev
Hi Erik, > Thank you all for the feedback and insights. > > Yes, the intention is to *replace* expand_inherited_rtentry() in the same way > planner_hook replaces standard_planner(). This patch probably doesn't need yet another reviewer, but since there is a little controversy about if the hook s

Re: Feedback on table expansion hook (including patch)

2021-03-29 Thread Erik Nordström
Thank you all for the feedback and insights. Yes, the intention is to *replace* expand_inherited_rtentry() in the same way planner_hook replaces standard_planner(). Some background: TimescaleDB implements its own partitioning based on inheritance that predates declarative partitioning. The extens

Re: Feedback on table expansion hook (including patch)

2021-03-06 Thread David Fetter
On Sat, Mar 06, 2021 at 01:09:10PM -0500, Tom Lane wrote: > Peter Eisentraut writes: > > On 07.05.20 10:11, Erik Nordström wrote: > >> I am looking for feedback on the possibility of adding a table expansion > >> hook to PostgreSQL (see attached patch). > > > Unlike the get_relation_info_hook, y

Re: Feedback on table expansion hook (including patch)

2021-03-06 Thread Tom Lane
Peter Eisentraut writes: > On 07.05.20 10:11, Erik Nordström wrote: >> I am looking for feedback on the possibility of adding a table expansion >> hook to PostgreSQL (see attached patch). > Unlike the get_relation_info_hook, your proposed hook would *replace* > expand_inherited_rtentry() rather

Re: Feedback on table expansion hook (including patch)

2021-03-04 Thread Peter Eisentraut
On 07.05.20 10:11, Erik Nordström wrote: I am looking for feedback on the possibility of adding a table expansion hook to PostgreSQL (see attached patch). The motivation for this is to allow extensions to optimize table expansion. In particular, TimescaleDB does its own table expansion in order

Re: Feedback on table expansion hook (including patch)

2020-11-02 Thread Anastasia Lubennikova
Status update for a commitfest entry. This patch implements useful improvement and the reviewer approved the code. It lacks a test, but looking at previously committed hooks, I think it is not mandatory. So, I move it to RFC. The new status of this patch is: Ready for Committer

Re: Feedback on table expansion hook (including patch)

2020-09-15 Thread Euler Taveira
On Thu, 7 May 2020 at 05:11, Erik Nordström wrote: > > I am looking for feedback on the possibility of adding a table expansion > hook to PostgreSQL (see attached patch). The motivation for this is to > allow extensions to optimize table expansion. In particular, TimescaleDB > does its own table

Re: Feedback on table expansion hook (including patch)

2020-05-07 Thread Hans-Jürgen Schönig (PostgreSQL)
that sounds really really useful. i can see a ton of use cases for that. we also toyed with the idea recently of having pluggable FSM strategies. that one could be quite useful as well. regards, hans > On 07.05.2020, at 10:11, Erik Nordström wrote: > > Hi, > > I am lo

Feedback on table expansion hook (including patch)

2020-05-07 Thread Erik Nordström
Hi, I am looking for feedback on the possibility of adding a table expansion hook to PostgreSQL (see attached patch). The motivation for this is to allow extensions to optimize table expansion. In particular, TimescaleDB does its own table expansion in order to apply a number of optimizations, inc