Re: Failed to delete old ReorderBuffer spilled files

2018-01-09 Thread atorikoshi
On 2018/01/06 0:30, Alvaro Herrera wrote: Ahh, so the reason I didn't see these crashes is that Atsushi had already fixed them. Nice. It would be *very* good to trim the quoted material when you reply --- don't leave everything, just enough lines for context. I would have seen this comment if

Re: Failed to delete old ReorderBuffer spilled files

2018-01-05 Thread Alvaro Herrera
atorikoshi wrote: > > FYI "make check" in contrib/test_decoding fails a couple of isolation > > tests, one with an assertion failure for my automatic patch tester[1]. > > Same result on my laptop: > > > > test ondisk_startup ... FAILED (test process exited with exit > > code 1) > > tes

Re: Failed to delete old ReorderBuffer spilled files

2018-01-05 Thread Alvaro Herrera
Thomas Munro wrote: > On Wed, Nov 22, 2017 at 12:27 AM, atorikoshi > wrote: > > [set_final_lsn_2.patch] > > Hi Torikoshi-san, > > FYI "make check" in contrib/test_decoding fails a couple of isolation > tests, one with an assertion failure for my automatic patch tester[1]. > Same result on my lap

Re: Failed to delete old ReorderBuffer spilled files

2017-11-23 Thread Craig Ringer
On 24 November 2017 at 12:38, atorikoshi wrote: > > > On 2017/11/24 10:57, Craig Ringer wrote: > > On 24 November 2017 at 09:20, atorikoshi co.jp > >> wrote: > > > >> > >> Thanks for letting me know. > >> I think I only tested running "make check" at top directory, sorry > >> for my insufficient

Re: Failed to delete old ReorderBuffer spilled files

2017-11-23 Thread atorikoshi
On 2017/11/24 10:57, Craig Ringer wrote: > On 24 November 2017 at 09:20, atorikoshi >> wrote: > >> >> Thanks for letting me know. >> I think I only tested running "make check" at top directory, sorry >> for my insufficient test. >> >> The test failure happened at the beginning of replication(c

Re: Failed to delete old ReorderBuffer spilled files

2017-11-23 Thread Craig Ringer
On 24 November 2017 at 09:20, atorikoshi wrote: > > Thanks for letting me know. > I think I only tested running "make check" at top directory, sorry > for my insufficient test. > > The test failure happened at the beginning of replication(creating > slot), so there are no changes yet and getting

Re: Failed to delete old ReorderBuffer spilled files

2017-11-23 Thread atorikoshi
On 2017/11/22 16:49, Masahiko Sawada wrote: On Wed, Nov 22, 2017 at 2:56 PM, Craig Ringer wrote: On 22 November 2017 at 12:15, Kyotaro HORIGUCHI wrote: At Wed, 22 Nov 2017 12:57:34 +0900, Michael Paquier wrote in On Wed, Nov 22, 2017 at 11:49 AM, Craig Ringer wrote: On 20 November 2017

Re: Failed to delete old ReorderBuffer spilled files

2017-11-22 Thread Thomas Munro
On Wed, Nov 22, 2017 at 12:27 AM, atorikoshi wrote: > [set_final_lsn_2.patch] Hi Torikoshi-san, FYI "make check" in contrib/test_decoding fails a couple of isolation tests, one with an assertion failure for my automatic patch tester[1]. Same result on my laptop: test ondisk_startup ..

Re: Failed to delete old ReorderBuffer spilled files

2017-11-21 Thread Masahiko Sawada
On Wed, Nov 22, 2017 at 2:56 PM, Craig Ringer wrote: > On 22 November 2017 at 12:15, Kyotaro HORIGUCHI > wrote: >> >> At Wed, 22 Nov 2017 12:57:34 +0900, Michael Paquier >> wrote in >> >> > On Wed, Nov 22, 2017 at 11:49 AM, Craig Ringer >> > wrote: >> > > On 20 November 2017 at 18:35, atorikos

Re: Failed to delete old ReorderBuffer spilled files

2017-11-21 Thread Craig Ringer
On 22 November 2017 at 12:15, Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > At Wed, 22 Nov 2017 12:57:34 +0900, Michael Paquier < > michael.paqu...@gmail.com> wrote in tzwhp2oeervv7r...@mail.gmail.com> > > On Wed, Nov 22, 2017 at 11:49 AM, Craig Ringer > wrote: > > > On 20 Novemb

Re: Failed to delete old ReorderBuffer spilled files

2017-11-21 Thread Kyotaro HORIGUCHI
At Wed, 22 Nov 2017 12:57:34 +0900, Michael Paquier wrote in > On Wed, Nov 22, 2017 at 11:49 AM, Craig Ringer wrote: > > On 20 November 2017 at 18:35, atorikoshi > > wrote: > >> I put many queries into one transaction and made ReorderBuffer spill > >> data to disk, and sent SIGKILL to postgres

Re: Failed to delete old ReorderBuffer spilled files

2017-11-21 Thread Michael Paquier
On Wed, Nov 22, 2017 at 11:49 AM, Craig Ringer wrote: > On 20 November 2017 at 18:35, atorikoshi > wrote: >> I put many queries into one transaction and made ReorderBuffer spill >> data to disk, and sent SIGKILL to postgres before the end of the >> transaction. >> >> After starting up postgres ag

Re: Failed to delete old ReorderBuffer spilled files

2017-11-21 Thread Craig Ringer
On 20 November 2017 at 18:35, atorikoshi wrote: > Hi, > > I put many queries into one transaction and made ReorderBuffer spill > data to disk, and sent SIGKILL to postgres before the end of the > transaction. > > After starting up postgres again, I observed the files spilled to > data wasn't dele

Re: Failed to delete old ReorderBuffer spilled files

2017-11-21 Thread Kyotaro HORIGUCHI
Hi, At Wed, 22 Nov 2017 10:10:27 +0900, Masahiko Sawada wrote in > >> Using last changing LSN might work but I'm afraid that that fails > >> to remove the last snap file if the crash happens at the very > >> start of a segment. > > I think it works even in the case because the we can compute t

Re: Failed to delete old ReorderBuffer spilled files

2017-11-21 Thread Masahiko Sawada
On Wed, Nov 22, 2017 at 9:03 AM, Kyotaro HORIGUCHI wrote: > At Tue, 21 Nov 2017 20:53:04 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI > wrote in > <20171121.205304.90315453.horiguchi.kyot...@lab.ntt.co.jp> >> At Tue, 21 Nov 2017 20:27:25 +0900, atorikoshi >> wrote in >> >> > Thanks for re

Re: Failed to delete old ReorderBuffer spilled files

2017-11-21 Thread Kyotaro HORIGUCHI
At Tue, 21 Nov 2017 20:53:04 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20171121.205304.90315453.horiguchi.kyot...@lab.ntt.co.jp> > At Tue, 21 Nov 2017 20:27:25 +0900, atorikoshi > wrote in > > > Thanks for reviewing! > > > > > > On 2017/11/21 18:12, Masahiko Sawada wrote: >

Re: Failed to delete old ReorderBuffer spilled files

2017-11-21 Thread Kyotaro HORIGUCHI
Hello, At Tue, 21 Nov 2017 20:27:25 +0900, atorikoshi wrote in > Thanks for reviewing! > > > On 2017/11/21 18:12, Masahiko Sawada wrote: > > On Tue, Nov 21, 2017 at 3:48 PM, Masahiko Sawada > > wrote: > >> On Mon, Nov 20, 2017 at 7:35 PM, atorikoshi > >> wrote: > >>> Hi, > >>> > >>> I put

Re: Failed to delete old ReorderBuffer spilled files

2017-11-21 Thread atorikoshi
Thanks for reviewing! On 2017/11/21 18:12, Masahiko Sawada wrote: On Tue, Nov 21, 2017 at 3:48 PM, Masahiko Sawada wrote: On Mon, Nov 20, 2017 at 7:35 PM, atorikoshi wrote: Hi, I put many queries into one transaction and made ReorderBuffer spill data to disk, and sent SIGKILL to postgres b

Re: Failed to delete old ReorderBuffer spilled files

2017-11-21 Thread Masahiko Sawada
On Tue, Nov 21, 2017 at 3:48 PM, Masahiko Sawada wrote: > On Mon, Nov 20, 2017 at 7:35 PM, atorikoshi > wrote: >> Hi, >> >> I put many queries into one transaction and made ReorderBuffer spill >> data to disk, and sent SIGKILL to postgres before the end of the >> transaction. >> >> After starting

Re: Failed to delete old ReorderBuffer spilled files

2017-11-20 Thread Masahiko Sawada
On Mon, Nov 20, 2017 at 7:35 PM, atorikoshi wrote: > Hi, > > I put many queries into one transaction and made ReorderBuffer spill > data to disk, and sent SIGKILL to postgres before the end of the > transaction. > > After starting up postgres again, I observed the files spilled to > data wasn't de

Failed to delete old ReorderBuffer spilled files

2017-11-20 Thread atorikoshi
Hi, I put many queries into one transaction and made ReorderBuffer spill data to disk, and sent SIGKILL to postgres before the end of the transaction. After starting up postgres again, I observed the files spilled to data wasn't deleted. I think these files should be deleted because its transac