On Wed, Nov 22, 2017 at 11:49 AM, Craig Ringer <cr...@2ndquadrant.com> wrote: > On 20 November 2017 at 18:35, atorikoshi > <torikoshi_atsushi...@lab.ntt.co.jp> wrote: >> I put many queries into one transaction and made ReorderBuffer spill >> data to disk, and sent SIGKILL to postgres before the end of the >> transaction. >> >> After starting up postgres again, I observed the files spilled to >> data wasn't deleted. > > Since this can only happen on crash exits, and the reorderbuffer data is > useless after a decoding backend exits, why don't we just recursively delete > the tree contents on Pg startup?
+1. You would just need an extra step after say DeleteAllExportedSnapshotFiles() in startup.c. Looks saner to me do so so as well. -- Michael
