Re: Escape output of pg_amcheck test

2024-01-13 Thread Peter Eisentraut
On 08.01.24 16:06, Peter Eisentraut wrote: On 08.01.24 15:04, Aleksander Alekseev wrote: [...] so I quickly wrote some (wrong) instrumentation to try to test your patch. Yep, it confused me too at first. Since the encoding happens right before exit() call, maybe it's worth changing $b in-plac

Re: Escape output of pg_amcheck test

2024-01-08 Thread Peter Eisentraut
On 08.01.24 15:04, Aleksander Alekseev wrote: [...] so I quickly wrote some (wrong) instrumentation to try to test your patch. Yep, it confused me too at first. Since the encoding happens right before exit() call, maybe it's worth changing $b in-place in order to make the code slightly more re

Re: Escape output of pg_amcheck test

2024-01-08 Thread Aleksander Alekseev
Hi, > [...] so I quickly wrote some (wrong) instrumentation to try to test your > patch. Yep, it confused me too at first. Since the encoding happens right before exit() call, maybe it's worth changing $b in-place in order to make the code slightly more readable for most of us :) -- Best rega

Re: Escape output of pg_amcheck test

2024-01-08 Thread Mark Dilger
> On Jan 8, 2024, at 5:41 AM, Mark Dilger wrote: > > The /r modifier defeats the purpose of the patch, at least for my perl > version, perl 5, version 28, subversion 1 (v5.28.1). With just the /aeg > modifier, it works fine. Nevermind. I might be wrong about that. I didn't have a test ca

Re: Escape output of pg_amcheck test

2024-01-08 Thread Mark Dilger
On 1/7/24 23:27, Peter Eisentraut wrote: The pg_amcheck reports a skip message if the layout of the index does not match expectations.  That message includes the bytes that were expected and the ones that were found.  But the found ones are arbitrary bytes, which can have funny effects on th

Re: Escape output of pg_amcheck test

2024-01-08 Thread Aleksander Alekseev
Hi, > The pg_amcheck reports a skip message if the layout of the index does > not match expectations. That message includes the bytes that were > expected and the ones that were found. But the found ones are arbitrary > bytes, which can have funny effects on the terminal when they are > printed.

Escape output of pg_amcheck test

2024-01-07 Thread Peter Eisentraut
that, escape non-word characters before printing.From 09d82d19e045114b1e2e7c3751e96cbae1eaaa0c Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 8 Jan 2024 08:23:26 +0100 Subject: [PATCH] Escape output of pg_amcheck test The pg_amcheck reports a skip message if the layout of the index