Re: Enhance create subscription reference manual

2024-10-18 Thread Amit Kapila
On Fri, Oct 18, 2024 at 9:46 AM Tatsuo Ishii wrote: > > Hi Amit, > > > On Thu, Oct 3, 2024 at 8:53 AM Tatsuo Ishii wrote: > >> > >> > parameter in this case (it is an "optional" parameter, though). However, > >> > when we refer to the stored catalog value, we should call it an option or > >> > a

Re: Enhance create subscription reference manual

2024-10-17 Thread Tatsuo Ishii
Hi Amit, > On Thu, Oct 3, 2024 at 8:53 AM Tatsuo Ishii wrote: >> >> > parameter in this case (it is an "optional" parameter, though). However, >> > when we refer to the stored catalog value, we should call it an option or >> > a property and calling it parameter is not suitable. >> >> Not sure. T

Re: Enhance create subscription reference manual

2024-10-13 Thread Amit Kapila
On Thu, Oct 3, 2024 at 8:53 AM Tatsuo Ishii wrote: > > > parameter in this case (it is an "optional" parameter, though). However, > > when we refer to the stored catalog value, we should call it an option or > > a property and calling it parameter is not suitable. > > Not sure. The stored catalog

Re: Enhance create subscription reference manual

2024-10-07 Thread Yugo NAGATA
On Thu, 03 Oct 2024 12:23:34 +0900 (JST) Tatsuo Ishii wrote: > > parameter in this case (it is an "optional" parameter, though). However, > > when we refer to the stored catalog value, we should call it an option or > > a property and calling it parameter is not suitable. > > Not sure. The store

Re: Enhance create subscription reference manual

2024-10-02 Thread Tatsuo Ishii
> parameter in this case (it is an "optional" parameter, though). However, > when we refer to the stored catalog value, we should call it an option or > a property and calling it parameter is not suitable. Not sure. The stored catalog value of a subscription can be changed ALTER SUBSCRIPTION. In t

Re: Enhance create subscription reference manual

2024-10-02 Thread Yugo Nagata
On Wed, 2 Oct 2024 17:09:42 -0700 "David G. Johnston" wrote: > On Wednesday, October 2, 2024, Peter Smith wrote: > > > ` > > - "subscription's failover option" > > > > Feels like this one refers to the stored catalog value, which is neither a > parameter nor an option but an attribute. Though

Re: Enhance create subscription reference manual

2024-10-02 Thread Peter Smith
On Thu, Oct 3, 2024 at 10:01 AM David G. Johnston wrote: > > On Wednesday, October 2, 2024, Peter Smith wrote: >> >> >> >> You can see how confused the current docs are because "failover" is >> called by both terms even within the same paragraph! [1] >> - "failover parameter specified in the subs

Re: Enhance create subscription reference manual

2024-10-02 Thread David G. Johnston
On Wednesday, October 2, 2024, Peter Smith wrote: > ` > - "subscription's failover option" > Feels like this one refers to the stored catalog value, which is neither a parameter nor an option but an attribute. Though in some cases we are using “property” as well. An in this usage option sorta

Re: Enhance create subscription reference manual

2024-10-02 Thread David G. Johnston
On Wednesday, October 2, 2024, Peter Smith wrote: > > > You can see how confused the current docs are because "failover" is > called by both terms even within the same paragraph! [1] > - "failover parameter specified in the subscription" > - "subscription's failover option" > > ~~~ > > What to do

Re: Enhance create subscription reference manual

2024-10-02 Thread Peter Smith
On Wed, Oct 2, 2024 at 6:17 PM Yugo NAGATA wrote: > > > > > I would like to hear opinions from native English speakers. > > +1 > Hi, You can look up the definitions of the words "option" versus "parameter". They do have different meanings, like: - An "option" is a modifier that affects how a co

Re: Enhance create subscription reference manual

2024-10-02 Thread Yugo NAGATA
On Wed, 02 Oct 2024 16:25:35 +0900 (JST) Tatsuo Ishii wrote: > > Also, the "public" parameter in CREATE PUBLICATION doc, > > You mean "publish"? Yes. Sorry for the typo. > > > "vacuum_index_cleanup" and > > "vacuum_truncate" storage parameters in CREATE TABLE doc might be also > > targets t

Re: Enhance create subscription reference manual

2024-10-02 Thread Tatsuo Ishii
>> > I agreed with adding tag to "failover" since it is done in the >> > description on "slot_name" parameter. >> > >> > How about also rewrite it to "enable the failover option" rather than >> > simply >> > "enable the failover" to clarify that the parameter is refereed to. >> > >> > We could

Re: Enhance create subscription reference manual

2024-10-01 Thread Yugo NAGATA
On Wed, 02 Oct 2024 14:52:58 +0900 (JST) Tatsuo Ishii wrote: > >> Currently the manual explains create subscription's "failover" > >> parameter as follows: > >> > >> > >> Since no connection is made when this option is > >> false, no tables are subscribed. To initia

Re: Enhance create subscription reference manual

2024-10-01 Thread Tatsuo Ishii
>> Currently the manual explains create subscription's "failover" >> parameter as follows: >> >> >> Since no connection is made when this option is >> false, no tables are subscribed. To initiate >> replication, you must manually create the replication slot,

Re: Enhance create subscription reference manual

2024-10-01 Thread Yugo Nagata
On Wed, 02 Oct 2024 12:15:50 +0900 (JST) Tatsuo Ishii wrote: > Currently the manual explains create subscription's "failover" > parameter as follows: > > > Since no connection is made when this option is > false, no tables are subscribed. To initiate > rep

Enhance create subscription reference manual

2024-10-01 Thread Tatsuo Ishii
Currently the manual explains create subscription's "failover" parameter as follows: Since no connection is made when this option is false, no tables are subscribed. To initiate replication, you must manually create the replication slot, enable the