On Thu, Oct 3, 2024 at 8:53 AM Tatsuo Ishii <is...@postgresql.org> wrote: > > > parameter in this case (it is an "optional" parameter, though). However, > > when we refer to the stored catalog value, we should call it an option or > > a property and calling it parameter is not suitable. > > Not sure. The stored catalog value of a subscription can be changed > ALTER SUBSCRIPTION. In the ALTER SUBSCRIPTION manual, the placeholders > for these properties are "parameter". So I think we should use > "parameter" in this case at least for the stored catalog values of > subscriptions. > > > If so, I feel that "the failover" in the following statement means > > the catalog value (or the failover feature itself), so we should not > > rewrite this to "the failover parameter". > > My conclusion is we should rewrite it as "the failover parameter" for > the reason above. > > >> To initiate replication, you must manually create the replication slot, > >> enable the failover if required, enable the subscription, and refresh the > >> subscription. > > > > Instead, should we use "failover option"? >
Sounds reasonable to me. Would you like to propose the patch with the changes you have in mind? -- With Regards, Amit Kapila.
