Re: Documentation fix for adding a column with a default value

2019-07-18 Thread Michael Paquier
On Fri, Jul 19, 2019 at 09:04:03AM +0900, Ian Barwick wrote: > To me it looks like a minor documentation correction to fix an omission > from a patch already in PostgreSQL. I think that it is better to register it in the commit fest anyway so as we don't lose track of it. Things tend to get lost

Re: Documentation fix for adding a column with a default value

2019-07-18 Thread Ian Barwick
On 7/19/19 12:51 AM, Daniel Gustafsson wrote: On 18 Jul 2019, at 17:46, Daniel Westermann (DWE) wrote: The suggested change pares down the "Tip" to more of a brief "Note", which IMHO is a bit terse for that section of the documentation (which has more of a tutorial character), and the conte

Re: Documentation fix for adding a column with a default value

2019-07-18 Thread Daniel Gustafsson
> On 18 Jul 2019, at 17:46, Daniel Westermann (DWE) > wrote: > >>> The suggested change pares down the "Tip" to more of a brief "Note", which >>> IMHO is a bit >>> terse for that section of the documentation (which has more of a tutorial >>> character), >>> and the contents of the original tip

Re: Fw: Documentation fix for adding a column with a default value

2019-07-18 Thread Daniel Westermann (DWE)
>>The suggested change pares down the "Tip" to more of a brief "Note", which >>IMHO is a bit >>terse for that section of the documentation (which has more of a tutorial >>character), >>and the contents of the original tip basically still apply for volatile >>default values >>anyway. >> >>I've at

Re: Fw: Documentation fix for adding a column with a default value

2019-07-17 Thread Daniel Westermann (DWE)
>> Seems the first mail didn't make it ... >Actually it did, I was about to reply to it :) > >The suggested change pares down the "Tip" to more of a brief "Note", which >IMHO is a bit >terse for that section of the documentation (which has more of a tutorial >character), >and the contents of th

Re: Fw: Documentation fix for adding a column with a default value

2019-07-16 Thread Ian Barwick
On Wed, 17 Jul 2019 at 15:42, Daniel Westermann (DWE) < daniel.westerm...@dbi-services.com> wrote: > >__ > >From: Daniel Westermann (DWE) > >Sent: Monday, July 15, 2019 13:01 > >To: pgsql-hack...@postgresql.org > >Subject: D

Fw: Documentation fix for adding a column with a default value

2019-07-16 Thread Daniel Westermann (DWE)
>__ >From: Daniel Westermann (DWE) >Sent: Monday, July 15, 2019 13:01 >To: pgsql-hack...@postgresql.org >Subject: Documentation fix for adding a column with a default value > >Hi, > >the tip in the "Adding a column" section

Documentation fix for adding a column with a default value

2019-07-15 Thread Daniel Westermann (DWE)
Hi, the tip in the "Adding a column" section is not true anymore since PostgreSQL 11: https://www.postgresql.org/docs/current/ddl-alter.html#DDL-ALTER-ADDING-A-COLUMN Attached a patch proposal for this. Regards Daniel diff --git a/doc/src/sgml/ddl.sgml b/doc/src/sgml/ddl.sgml ind