Re: Displaying and dumping of table access methods

2019-01-11 Thread Amit Khandekar
On Fri, 11 Jan 2019 at 14:47, Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > On Fri, Jan 11, 2019 at 6:02 AM Amit Khandekar > > wrote: > > > > > Yes, sounds like a reasonable approach, I can proceed with it. > > > > Dmitry, I believe you have taken the pg_dump part only. If that's > > right,

Re: Displaying and dumping of table access methods

2019-01-11 Thread Dmitry Dolgov
> On Fri, Jan 11, 2019 at 6:02 AM Amit Khandekar wrote: > > > Yes, sounds like a reasonable approach, I can proceed with it. > > Dmitry, I believe you have taken the pg_dump part only. If that's > right, I can proceed with the psql part. Does that sound right ? Well, actually I've meant that I'm

Re: Displaying and dumping of table access methods

2019-01-11 Thread Peter Eisentraut
On 10/01/2019 04:58, Amit Kapila wrote: >> One flag that covers all things that make psql output less useful for >> regression test output, or one flag that just controls the table access >> method display. >> > +1 for the later (one flag that just controls the table access method > display) as tha

Re: Displaying and dumping of table access methods

2019-01-10 Thread Amit Khandekar
On Wed, 9 Jan 2019 at 14:30, Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > On Tue, Jan 8, 2019 at 6:34 PM Andres Freund wrote: > > > > On 2019-01-08 11:30:56 +0100, Peter Eisentraut wrote: > > > On 08/01/2019 00:56, Andres Freund wrote: > > > > A patch at [2] adds display of a table's access

Re: Displaying and dumping of table access methods

2019-01-09 Thread Amit Kapila
On Wed, Jan 9, 2019 at 10:53 PM Andres Freund wrote: > > Hi, > > On 2019-01-09 18:26:16 +0530, Amit Kapila wrote: > > On Tue, Jan 8, 2019 at 11:04 PM Andres Freund wrote: > > +1. > > > > > Don't like it > > > too much, but it seems better than the alternative. I wonder if we want > > > one for m

Re: Displaying and dumping of table access methods

2019-01-09 Thread Andres Freund
Hi, On 2019-01-09 18:26:16 +0530, Amit Kapila wrote: > On Tue, Jan 8, 2019 at 11:04 PM Andres Freund wrote: > +1. > > > Don't like it > > too much, but it seems better than the alternative. I wonder if we want > > one for multiple regression related issues, or whether one specifically > > about

Re: Displaying and dumping of table access methods

2019-01-09 Thread Amit Kapila
On Tue, Jan 8, 2019 at 11:04 PM Andres Freund wrote: > > Hi, > > On 2019-01-08 11:30:56 +0100, Peter Eisentraut wrote: > > On 08/01/2019 00:56, Andres Freund wrote: > > > A patch at [2] adds display of a table's access method to \d+ - but that > > > means that running the tests with a different de

Re: Displaying and dumping of table access methods

2019-01-09 Thread Dmitry Dolgov
> On Tue, Jan 8, 2019 at 6:34 PM Andres Freund wrote: > > On 2019-01-08 11:30:56 +0100, Peter Eisentraut wrote: > > On 08/01/2019 00:56, Andres Freund wrote: > > > A patch at [2] adds display of a table's access method to \d+ - but that > > > means that running the tests with a different default t

Re: Displaying and dumping of table access methods

2019-01-08 Thread Michael Paquier
On Tue, Jan 08, 2019 at 09:29:49AM -0800, Andres Freund wrote: > On 2019-01-08 13:02:00 +0900, Michael Paquier wrote: >> The specific-heap tests could be included as an extra module in >> src/test/modules easily, so removing from the main tests what is not >> completely transparent may make sense.

Re: Displaying and dumping of table access methods

2019-01-08 Thread Andres Freund
Hi, On 2019-01-08 11:30:56 +0100, Peter Eisentraut wrote: > On 08/01/2019 00:56, Andres Freund wrote: > > A patch at [2] adds display of a table's access method to \d+ - but that > > means that running the tests with a different default table access > > method (e.g. using PGOPTIONS='-c default_tab

Re: Displaying and dumping of table access methods

2019-01-08 Thread Andres Freund
Hi, On 2019-01-08 13:02:00 +0900, Michael Paquier wrote: > On Mon, Jan 07, 2019 at 06:31:52PM -0800, Andres Freund wrote: > > Huh? It's absolutely *trivial* from a buildsystem POV to run the tests > > again with a different default AM. That's precisely why I'm talking > > about this. Just setting

Re: Displaying and dumping of table access methods

2019-01-08 Thread Peter Eisentraut
On 08/01/2019 00:56, Andres Freund wrote: > A patch at [2] adds display of a table's access method to \d+ - but that > means that running the tests with a different default table access > method (e.g. using PGOPTIONS='-c default_table_access_method=...) > there'll be a significant number of test fa

Re: Displaying and dumping of table access methods

2019-01-08 Thread Haribabu Kommi
On Tue, Jan 8, 2019 at 3:02 PM Michael Paquier wrote: > On Mon, Jan 07, 2019 at 06:31:52PM -0800, Andres Freund wrote: > > Huh? It's absolutely *trivial* from a buildsystem POV to run the tests > > again with a different default AM. That's precisely why I'm talking > > about this. Just setting PG

Re: Displaying and dumping of table access methods

2019-01-07 Thread Michael Paquier
On Mon, Jan 07, 2019 at 06:31:52PM -0800, Andres Freund wrote: > Huh? It's absolutely *trivial* from a buildsystem POV to run the tests > again with a different default AM. That's precisely why I'm talking > about this. Just setting PGOPTIONS='-c > default_table_access_method=zheap' in the new make

Re: Displaying and dumping of table access methods

2019-01-07 Thread Andres Freund
Hi, On 2019-01-07 21:08:58 -0500, Stephen Frost wrote: > * Andres Freund (and...@anarazel.de) wrote: > > On 2019-01-07 20:30:13 -0500, Stephen Frost wrote: > > > I don't agree with the general assumption that "we did this for > > > development and therefore it should be done that way forever". > >

Re: Displaying and dumping of table access methods

2019-01-07 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-01-07 20:30:13 -0500, Stephen Frost wrote: > > * Andres Freund (and...@anarazel.de) wrote: > > > On 2019-01-07 19:19:46 -0500, Stephen Frost wrote: > > > > * Andres Freund (and...@anarazel.de) wrote: > > > > > Over in [1] we're discu

Re: Displaying and dumping of table access methods

2019-01-07 Thread Andres Freund
Hi, On 2019-01-07 20:30:13 -0500, Stephen Frost wrote: > * Andres Freund (and...@anarazel.de) wrote: > > On 2019-01-07 19:19:46 -0500, Stephen Frost wrote: > > > * Andres Freund (and...@anarazel.de) wrote: > > > > Over in [1] we're discussing the development of the pluggable storage > > > > patchs

Re: Displaying and dumping of table access methods

2019-01-07 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-01-07 19:19:46 -0500, Stephen Frost wrote: > > * Andres Freund (and...@anarazel.de) wrote: > > > Over in [1] we're discussing the development of the pluggable storage > > > patchset, which allows different ways of storing table data.

Re: Displaying and dumping of table access methods

2019-01-07 Thread Andres Freund
Hi, On 2019-01-07 19:19:46 -0500, Stephen Frost wrote: > Greetings, > > * Andres Freund (and...@anarazel.de) wrote: > > Over in [1] we're discussing the development of the pluggable storage > > patchset, which allows different ways of storing table data. > > > > One thing I'd like to discuss wit

Re: Displaying and dumping of table access methods

2019-01-07 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > Over in [1] we're discussing the development of the pluggable storage > patchset, which allows different ways of storing table data. > > One thing I'd like to discuss with a wider audience than the > implementation details is psql and pg_du

Displaying and dumping of table access methods

2019-01-07 Thread Andres Freund
Hi, Over in [1] we're discussing the development of the pluggable storage patchset, which allows different ways of storing table data. One thing I'd like to discuss with a wider audience than the implementation details is psql and pg_dump handling of table access methods. Currently the patchset