Re: DROP OWNED BY is broken on master branch.

2022-09-28 Thread Robert Haas
On Wed, Sep 28, 2022 at 8:21 AM Rushabh Lathia wrote: > On Tue, Sep 27, 2022 at 7:34 PM Robert Haas wrote: >> On Tue, Sep 27, 2022 at 2:53 AM Rushabh Lathia >> wrote: >> > Yes, I was also thinking to avoid the duplicate logic but couldn't found >> > a way. I did the quick testing with the patc

Re: DROP OWNED BY is broken on master branch.

2022-09-28 Thread Rushabh Lathia
On Tue, Sep 27, 2022 at 7:34 PM Robert Haas wrote: > On Tue, Sep 27, 2022 at 2:53 AM Rushabh Lathia > wrote: > > Yes, I was also thinking to avoid the duplicate logic but couldn't found > > a way. I did the quick testing with the patch, and reported test is > working > > fine. But "make chec

Re: DROP OWNED BY is broken on master branch.

2022-09-27 Thread Robert Haas
On Tue, Sep 27, 2022 at 2:53 AM Rushabh Lathia wrote: > Yes, I was also thinking to avoid the duplicate logic but couldn't found > a way. I did the quick testing with the patch, and reported test is working > fine. But "make check" is failing with few failures. Oh, woops. There was a dumb mis

Re: DROP OWNED BY is broken on master branch.

2022-09-26 Thread Rushabh Lathia
On Mon, Sep 26, 2022 at 11:46 PM Robert Haas wrote: > On Mon, Sep 26, 2022 at 3:44 AM Rushabh Lathia > wrote: > > Commit 6566133c5f52771198aca07ed18f84519fac1be7 ensure that > > pg_auth_members.grantor is always valid. This commit did changes > > into shdepDropOwned() function and combined the

Re: DROP OWNED BY is broken on master branch.

2022-09-26 Thread Robert Haas
On Mon, Sep 26, 2022 at 3:44 AM Rushabh Lathia wrote: > Commit 6566133c5f52771198aca07ed18f84519fac1be7 ensure that > pg_auth_members.grantor is always valid. This commit did changes > into shdepDropOwned() function and combined the SHARED_DEPENDENCY_ACL > and SHARED_DEPENDENCY_OWNER. In that pr

Re: DROP OWNED BY is broken on master branch.

2022-09-26 Thread Michael Paquier
On Mon, Sep 26, 2022 at 01:13:53PM +0530, Rushabh Lathia wrote: > Please find the attached patch which fixes the case. Could it be possible to stress this stuff in the regression tests? There is a gap here. (I have not looked at what you are proposing.) -- Michael signature.asc Description: PGP

DROP OWNED BY is broken on master branch.

2022-09-26 Thread Rushabh Lathia
Hi All, Consider the below test: postgres@53130=#create role test WITH login createdb; CREATE ROLE postgres@53130=#\c - test You are now connected to database "postgres" as user "test". postgres@53150=#create database test; CREATE DATABASE postgres@53150=#\c - rushabh You are now connected to dat