On Mon, Sep 26, 2022 at 11:46 PM Robert Haas <robertmh...@gmail.com> wrote:
> On Mon, Sep 26, 2022 at 3:44 AM Rushabh Lathia <rushabh.lat...@gmail.com> > wrote: > > Commit 6566133c5f52771198aca07ed18f84519fac1be7 ensure that > > pg_auth_members.grantor is always valid. This commit did changes > > into shdepDropOwned() function and combined the SHARED_DEPENDENCY_ACL > > and SHARED_DEPENDENCY_OWNER. In that process it removed condition for > > local object in owner dependency. > > > > case SHARED_DEPENDENCY_OWNER: > > - /* If a local object, save it for deletion below */ > > - if (sdepForm->dbid == MyDatabaseId) > > + /* Save it for deletion below */ > > > > Case ending up with above error because of the above removed condition. > > > > Please find the attached patch which fixes the case. > > Thanks for the report. I think it would be preferable not to duplicate > the logic as your version does, though, so here's a slightly different > version that avoids that. > Yes, I was also thinking to avoid the duplicate logic but couldn't found a way. I did the quick testing with the patch, and reported test is working fine. But "make check" is failing with few failures. > Per Michael's suggestion, I have also written a test case and included > it in this version. > Thanks for this. > Comments? > > -- > Robert Haas > EDB: http://www.enterprisedb.com > -- Rushabh Lathia
