On 9/23/24 21:58, Julien Tachoires wrote:
> Hi Tomas,
>
> Le lun. 23 sept. 2024 à 18:13, Tomas Vondra a écrit :
>>
>> Hi,
>>
>> I've spent a bit more time on this, mostly running tests to get a better
>> idea of the practical benefits.
>
> Thank you for your code review and testing!
>
>> Fir
Hi Tomas,
Le lun. 23 sept. 2024 à 18:13, Tomas Vondra a écrit :
>
> Hi,
>
> I've spent a bit more time on this, mostly running tests to get a better
> idea of the practical benefits.
Thank you for your code review and testing!
> Firstly, I think there's a bug in ReorderBufferCompress() - it's l
Hi,
I've spent a bit more time on this, mostly running tests to get a better
idea of the practical benefits.
Firstly, I think there's a bug in ReorderBufferCompress() - it's legal
for pglz_compress() to return -1. This can happen if the data is not
compressible, and would not fit into the output
On Tue, Jul 16, 2024 at 7:31 PM Tomas Vondra
wrote:
>
> On 7/16/24 14:52, Amit Kapila wrote:
> > On Tue, Jul 16, 2024 at 12:58 AM Tomas Vondra
> > wrote:
> >>
> >> FWIW I'd expect that to be handled at the libpq level - there's already
> >> a patch for that, but I haven't checked if it would hand
On 7/16/24 14:52, Amit Kapila wrote:
> On Tue, Jul 16, 2024 at 12:58 AM Tomas Vondra
> wrote:
>>
>> On 7/15/24 20:50, Julien Tachoires wrote:
>>> Hi,
>>>
>>> Le ven. 7 juin 2024 à 06:18, Julien Tachoires a écrit :
Le ven. 7 juin 2024 à 05:59, Tomas Vondra
a écrit :
>
>
On Tue, Jul 16, 2024 at 12:58 AM Tomas Vondra
wrote:
>
> On 7/15/24 20:50, Julien Tachoires wrote:
> > Hi,
> >
> > Le ven. 7 juin 2024 à 06:18, Julien Tachoires a écrit :
> >>
> >> Le ven. 7 juin 2024 à 05:59, Tomas Vondra
> >> a écrit :
> >>>
> >>> On 6/6/24 12:58, Julien Tachoires wrote:
> >>>
Le lun. 15 juil. 2024 à 12:28, Tomas Vondra
a écrit :
>
> On 7/15/24 20:50, Julien Tachoires wrote:
> > The last patch of this set is still in WIP, it adds the machinery
> > required for setting the compression methods as a subscription option:
> > CREATE SUBSCRIPTION ... WITH (spill_compression =
On 7/15/24 20:50, Julien Tachoires wrote:
> Hi,
>
> Le ven. 7 juin 2024 à 06:18, Julien Tachoires a écrit :
>>
>> Le ven. 7 juin 2024 à 05:59, Tomas Vondra
>> a écrit :
>>>
>>> On 6/6/24 12:58, Julien Tachoires wrote:
...
When compiled with LZ4 support (--with-lz4), this patch ena
Le ven. 7 juin 2024 à 05:59, Tomas Vondra
a écrit :
>
> On 6/6/24 12:58, Julien Tachoires wrote:
> > ...
> >
> > When compiled with LZ4 support (--with-lz4), this patch enables data
> > compression/decompression of these temporary files. Each transaction
> > change that must be written on disk (Re
On 6/6/24 12:58, Julien Tachoires wrote:
> ...
>
> When compiled with LZ4 support (--with-lz4), this patch enables data
> compression/decompression of these temporary files. Each transaction
> change that must be written on disk (ReorderBufferDiskChange) is now
> compressed and encapsulated in a ne
On 6/6/24 16:24, Alvaro Herrera wrote:
> On 2024-Jun-06, Amit Kapila wrote:
>
>> On Thu, Jun 6, 2024 at 4:28 PM Julien Tachoires wrote:
>>>
>>> When the content of a large transaction (size exceeding
>>> logical_decoding_work_mem) and its sub-transactions has to be
>>> reordered during logical de
On Fri, Jun 7, 2024 at 2:08 PM Dilip Kumar wrote:
>
> I think the compression option should be supported at the CREATE
> SUBSCRIPTION level instead of being controlled by a GUC. This way, we
> can decide on compression for each subscription individually rather
> than applying it to all subscribers
On Thu, Jun 6, 2024 at 7:54 PM Alvaro Herrera wrote:
>
> On 2024-Jun-06, Amit Kapila wrote:
>
> > On Thu, Jun 6, 2024 at 4:28 PM Julien Tachoires wrote:
> > >
> > > When the content of a large transaction (size exceeding
> > > logical_decoding_work_mem) and its sub-transactions has to be
> > > re
On Fri, Jun 7, 2024 at 2:39 PM Alvaro Herrera wrote:
>
> On 2024-Jun-07, Dilip Kumar wrote:
>
> > I think the compression option should be supported at the CREATE
> > SUBSCRIPTION level instead of being controlled by a GUC. This way, we
> > can decide on compression for each subscription individua
On 2024-Jun-07, Dilip Kumar wrote:
> I think the compression option should be supported at the CREATE
> SUBSCRIPTION level instead of being controlled by a GUC. This way, we
> can decide on compression for each subscription individually rather
> than applying it to all subscribers. It makes more s
On Thu, Jun 6, 2024 at 7:54 PM Alvaro Herrera wrote:
>
> On 2024-Jun-06, Amit Kapila wrote:
>
> > On Thu, Jun 6, 2024 at 4:28 PM Julien Tachoires wrote:
> > >
> > > When the content of a large transaction (size exceeding
> > > logical_decoding_work_mem) and its sub-transactions has to be
> > > re
Le jeu. 6 juin 2024 à 07:24, Alvaro Herrera a écrit :
>
> On 2024-Jun-06, Amit Kapila wrote:
>
> > On Thu, Jun 6, 2024 at 4:28 PM Julien Tachoires wrote:
> > >
> > > When the content of a large transaction (size exceeding
> > > logical_decoding_work_mem) and its sub-transactions has to be
> > > r
Le jeu. 6 juin 2024 à 06:40, Amit Kapila a écrit :
>
> On Thu, Jun 6, 2024 at 6:22 PM Julien Tachoires wrote:
> >
> > Le jeu. 6 juin 2024 à 04:13, Amit Kapila a écrit :
> > >
> > > On Thu, Jun 6, 2024 at 4:28 PM Julien Tachoires wrote:
> > > >
> > > > When the content of a large transaction (si
On 2024-Jun-06, Amit Kapila wrote:
> On Thu, Jun 6, 2024 at 4:28 PM Julien Tachoires wrote:
> >
> > When the content of a large transaction (size exceeding
> > logical_decoding_work_mem) and its sub-transactions has to be
> > reordered during logical decoding, then, all the changes are written
>
On Thu, Jun 6, 2024 at 6:22 PM Julien Tachoires wrote:
>
> Le jeu. 6 juin 2024 à 04:13, Amit Kapila a écrit :
> >
> > On Thu, Jun 6, 2024 at 4:28 PM Julien Tachoires wrote:
> > >
> > > When the content of a large transaction (size exceeding
> > > logical_decoding_work_mem) and its sub-transactio
Le jeu. 6 juin 2024 à 04:13, Amit Kapila a écrit :
>
> On Thu, Jun 6, 2024 at 4:28 PM Julien Tachoires wrote:
> >
> > When the content of a large transaction (size exceeding
> > logical_decoding_work_mem) and its sub-transactions has to be
> > reordered during logical decoding, then, all the chan
On Thu, Jun 6, 2024 at 4:43 PM Amit Kapila wrote:
>
> On Thu, Jun 6, 2024 at 4:28 PM Julien Tachoires wrote:
> >
> > When the content of a large transaction (size exceeding
> > logical_decoding_work_mem) and its sub-transactions has to be
> > reordered during logical decoding, then, all the chang
On Thu, Jun 6, 2024 at 4:28 PM Julien Tachoires wrote:
>
> When the content of a large transaction (size exceeding
> logical_decoding_work_mem) and its sub-transactions has to be
> reordered during logical decoding, then, all the changes are written
> on disk in temporary files located in pg_repls
we want a GUC to switch compression on/off?
Regards,
JT
v1-0001-Compress-ReorderBuffer-spill-files-using-LZ4.patch
Description: Binary data
24 matches
Mail list logo
