Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum

2020-07-04 Thread vignesh C
On Sat, Jul 4, 2020 at 12:32 PM Amit Kapila wrote: > > On Fri, Jul 3, 2020 at 5:18 PM Masahiko Sawada > wrote: > > > > On Fri, 3 Jul 2020 at 17:07, vignesh C wrote: > > > > > > Hi, > > > > > > While checking through the code I found that some of the function > > > parameters in reorderbuffer &

Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum

2020-07-04 Thread Amit Kapila
On Fri, Jul 3, 2020 at 5:18 PM Masahiko Sawada wrote: > > On Fri, 3 Jul 2020 at 17:07, vignesh C wrote: > > > > Hi, > > > > While checking through the code I found that some of the function > > parameters in reorderbuffer & vacuumlazy are not used. I felt this > > could be removed. I'm not sure

Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum

2020-07-03 Thread Tom Lane
Amit Kapila writes: > On Fri, Jul 3, 2020 at 2:06 PM Simon Riggs wrote: >> Seems like a change with low utility. > Yeah, all or most of the ReorderBuffer APIs seem to take the > "ReorderBuffer *" parameter, so not sure if removing from some of them > is useful or not. At least in the current fo

Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum

2020-07-03 Thread Amit Kapila
On Fri, Jul 3, 2020 at 2:06 PM Simon Riggs wrote: > > On Fri, 3 Jul 2020 at 09:07, vignesh C wrote: > >> >> While checking through the code I found that some of the function >> parameters in reorderbuffer & vacuumlazy are not used. I felt this >> could be removed. I'm not sure if it is kept for

Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum

2020-07-03 Thread Masahiko Sawada
On Fri, 3 Jul 2020 at 17:07, vignesh C wrote: > > Hi, > > While checking through the code I found that some of the function > parameters in reorderbuffer & vacuumlazy are not used. I felt this > could be removed. I'm not sure if it is kept for future use or not. > Attached patch contains the chan

Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum

2020-07-03 Thread Simon Riggs
On Fri, 3 Jul 2020 at 09:07, vignesh C wrote: > While checking through the code I found that some of the function > parameters in reorderbuffer & vacuumlazy are not used. I felt this > could be removed. I'm not sure if it is kept for future use or not. > Attached patch contains the changes for

Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum

2020-07-03 Thread vignesh C
Hi, While checking through the code I found that some of the function parameters in reorderbuffer & vacuumlazy are not used. I felt this could be removed. I'm not sure if it is kept for future use or not. Attached patch contains the changes for the same. Thoughts? Regards, Vignesh EnterpriseDB: